internal: remove experiments

Remove the deprecated-doc and deps-dev-link experiments, which
have been fully rolled out.

I found I also had to increase some parameters on the serializablity
test in internal/database to make it pass on my machine.
Reasons unknown.

Change-Id: Ibcb1f8167474884d6c029da55f2d31b3c5adcfc6
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/401237
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>

3 files changed, 3 insertions, 10 deletions

diff --git a/internal/database/database_test.go b/internal/database/database_test.go
index eda36ed0..e2ee75bb 100644
--- a/internal/database/database_test.go
+++ b/internal/database/database_test.go
@@ -372,12 +372,12 @@ func TestTransactSerializable(t *testing.T) {
 	// Test that serializable transactions retry until success.
 	// This test was taken from the example at https://www.postgresql.org/docs/11/transaction-iso.html,
 	// section 13.2.3.
-	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
+	ctx, cancel := context.WithTimeout(context.Background(), testTimeout*2)
 	defer cancel()
 
 	// Once in while, the test doesn't work. Repeat to de-flake.
 	var msg string
-	for i := 0; i < 10; i++ {
+	for i := 0; i < 20; i++ {
 		msg = testTransactSerializable(ctx, t)
 		if msg == "" {
 			return
diff --git a/internal/experiment.go b/internal/experiment.go
index d84e3d68..256bc9c4 100644
--- a/internal/experiment.go
+++ b/internal/experiment.go
@@ -6,23 +6,19 @@
 package internal
 
 const (
-	ExperimentDeprecatedDoc          = "deprecated-doc"
 	ExperimentEnableStdFrontendFetch = "enable-std-frontend-fetch"
 	ExperimentNewUnitLayout          = "new-unit-layout"
 	ExperimentStyleGuide             = "styleguide"
 	ExperimentVulns                  = "vulns"
-	ExperimentDepsDevLink            = "deps-dev-link"
 )
 
 // Experiments represents all of the active experiments in the codebase and
 // a description of each experiment.
 var Experiments = map[string]string{
-	ExperimentDeprecatedDoc:          "Treat deprecated symbols specially in documentation.",
 	ExperimentEnableStdFrontendFetch: "Enable frontend fetching for module std.",
 	ExperimentNewUnitLayout:          "Enable the new layout on the unit page.",
 	ExperimentStyleGuide:             "Enable the styleguide.",
 	ExperimentVulns:                  "Enable vulnerability reporting.",
-	ExperimentDepsDevLink:            "Enable link to Open Source Insights (deps.dev).",
 }
 
 // Experiment holds data associated with an experimental feature for frontend
diff --git a/internal/frontend/unit.go b/internal/frontend/unit.go
index 8696efea..f916467a 100644
--- a/internal/frontend/unit.go
+++ b/internal/frontend/unit.go
@@ -119,10 +119,7 @@ func (s *Server) serveUnitPage(ctx context.Context, w http.ResponseWriter, r *ht
 		return s.servePathNotFoundPage(w, r, ds, info.fullPath, info.modulePath, info.requestedVersion)
 	}
 
-	makeDepsDevURL := func() string { return "" }
-	if experiment.IsActive(ctx, internal.ExperimentDepsDevLink) {
-		makeDepsDevURL = depsDevURLGenerator(ctx, um)
-	}
+	makeDepsDevURL := depsDevURLGenerator(ctx, um)
 
 	// Use GOOS and GOARCH query parameters to create a build context, which
 	// affects the documentation and synopsis. Omitting both results in an empty