aboutsummaryrefslogtreecommitdiff
path: root/openpgp
AgeCommit message (Collapse)Author
2025-10-08all: fix some typos in commentcuishuang
Change-Id: Ia209f0a6d9b19d14e655c65d1287a1416b48c487 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/707535 Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Nicola Murino <nicola.murino@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev>
2024-12-04openpgp/clearsign: just use rand.Reader in testsv0.30.0Roland Shoemaker
Instead of a convoluted fake rand, it is _basically_ just as fast, and fixes errors that pop up due to bad entropy. Fixes golang/go#70682 Change-Id: Ib0f605398d1092b516b03135f602c644be2a060f Reviewed-on: https://go-review.googlesource.com/c/crypto/+/633655 Reviewed-by: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Roland Shoemaker <roland@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2024-06-26all: bump go.mod version and drop compatibility shimsFilippo Valsorda
Also, remove the legacy import annotations. Fixes golang/go#68147 Change-Id: Ibfcc9322f27224c0ba92ea42cd56912a7d8783fd Reviewed-on: https://go-review.googlesource.com/c/crypto/+/594256 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
2024-04-16openpgp: fix function name in commentcuishuang
Change-Id: Ic788ebe311fafa0f5d9750d5f7f25fb70dc0606d Reviewed-on: https://go-review.googlesource.com/c/crypto/+/579175 Run-TryBot: shuang cui <imcusg@gmail.com> Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
2023-03-20all: fix some commentscui fliter
Change-Id: Ia0410f1f3bb0a9ee68c6dbe1e6f62f65f9e00955 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/477755 Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Auto-Submit: Roland Shoemaker <roland@golang.org> Run-TryBot: shuang cui <imcusg@gmail.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
2023-01-30all: fix some commentscui fliter
Change-Id: I11030ee466c8cac6855ce4fe2cf72e0b8d7029f8 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/463796 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
2022-11-09all: remove redundant type conversioncui fliter
Change-Id: Ic6b210c1e5b99eef5c6e38d96feaf40e7e6033bb GitHub-Last-Rev: b8ecf761efe6a2eec78a805a99d778bdcdb938f9 GitHub-Pull-Request: golang/crypto#229 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/429016 Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>
2022-10-12all: fix a few function names on commentscui fliter
Change-Id: Iac9c8f06b874e62b56f634dede8757b87514f421 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/442135 Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Joedian Reid <joedian@golang.org>
2022-09-19all: replace io/ioutil with io and os packagecui fliter
For golang/go#45557 Change-Id: I447530cc66896aef7a8d528ccb8d095b80e3cf47 GitHub-Last-Rev: 5f385ff46487ac318bd1147cdbbd26bb0ffd0426 GitHub-Pull-Request: golang/crypto#230 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/430797 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Meng Zhuo <mzh@golangcn.org> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
2022-04-11all: gofmtRuss Cox
Gofmt to update doc comments to the new formatting. For golang/go#51082. Change-Id: I076031b6613691eefbb0f21739366e3fd2011ec9 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/399356 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
2021-08-13openpgp: fix deprecation messageRoland Shoemaker
Fixes the referenced issue and removes an unnecessary word. Change-Id: Icbf8bd26bccbc603e7dd360d817900ac2ca63a69 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/342049 Trust: Roland Shoemaker <roland@golang.org> Run-TryBot: Roland Shoemaker <roland@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-08-12openpgp: mark as deprecatedFilippo Valsorda
Finally. Fixes golang/go#44226 Change-Id: I73de5a49357f8891afef9094ab497f389b899943 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/341549 Trust: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org>
2020-03-02openpgp/packet: ensure that first partial packet is 512 bytesIan Lance Taylor
This requirement is from RFC 4880 4.2.2.4. Also simplify the partialLengthWriter loop. The old code worked but was written in a confusing way, with a loop whose terminating condition didn't make sense and was never true in practice. Rewrite it to more clearly do a set of partial writes of decreasing size. Fixes golang/go#32474 Change-Id: Ia53ceb39a34f1d6f2ea7c60190d52948bb0db59b Reviewed-on: https://go-review.googlesource.com/c/crypto/+/181121 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-01-17openpgp/armor: allow armored PGP signature without a CRCKatie Hockman
RFC 4800, Section 6 specifies that the CRC at the end of the armor is optional, so do not fail to decode signatures missing the CRC. Credit: armor.go patch from engineer at Google Change-Id: I39b04e0afaaafdf7aa86577fe4a35c50e7cf0b2b Reviewed-on: https://go-review.googlesource.com/c/crypto/+/215022 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2019-11-12openpgp/elgamal: prevent bad key from causing panic in DecryptKatie Hockman
If the mod inverse of the private key's P value does not exist, return an error in Decrypt rather than panic. Change-Id: Ia075a60108863b14ba98bb62364a17131423b819 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/573976 Reviewed-by: Filippo Valsorda <valsorda@google.com> Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205502 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2019-10-02openpgp/packet: support crypto.Decrypter in EncryptedKey.DecryptScott Ragan
Fixes golang/go#33301 Change-Id: I74a389367d34d4718d70349794027ed9f1eca370 GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188 GitHub-Pull-Request: golang/crypto#94 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-05-06openpgp: replace "currentTime" with "creationTime" as appropriateMatthew Dempsky
RFC 4880 uses the term "creation time" to refer to when keys and signatures are created, and this is partially followed already. This CL applies it to the rest of places that were using "currentTime" instead. Change-Id: I8a83604b53a240689327defd89e22ddbebe3b679 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/175446 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-04-24openpgp/clearsign: reject potentially misleading headers and messagesFilippo Valsorda
Aida Mynzhasova of SEC Consult Vulnerability Lab reported that the clearsign package accepts some malformed messages, which can make it possible for an attacker to trick a human user (but not a Go program) into thinking unverified text is part of the message. For example, if in the following message the vertical tab character is printed as a new line, a human observer could believe that the unverified header text is part of the signed message. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1\x0b\x0bThis text is part of the header. Hello world! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iJwEAQECAAYFAk8kMuEACgkQO9o98PRieSpMsAQAhmY/vwmNpflrPgmfWsYhk5O8 [...] MyTpno24AjIAGb+mH1U= =hIJ6 -----END PGP SIGNATURE----- The OpenPGP specs are delightfully vague about purpose and validation of these headers. RFC 4880, Section 7 says The cleartext signed message consists of: - The cleartext header '-----BEGIN PGP SIGNED MESSAGE-----' on a single line, - One or more "Hash" Armor Headers, - Exactly one empty line not included into the message digest, [...] but also If MD5 is the only hash used, then an implementation MAY omit this header for improved V2.x compatibility. and If more than one message digest is used in the signature, the "Hash" armor header contains a comma-delimited list of used message digests. which seems to suggest that there can be zero or more Hash headers, each with one or more algorithms, and no other header types. Anyway, it's entirely unclear what security purpose, if any, the Hash header accomplishes. If the hash is too weak to be secure or unsupported, the verification will fail. Otherwise, the user shouldn't care. Given its dubious function, avoid breaking abstractions to check that it matches the signature, and just document it as unverified. As for valid characters, RFC 4880 is silent, except reluctantly mentioning that the Comment header can be UTF-8, but I am going to assume that all hash algorithms will have ASCII names, because come on. Even more importantly, reject non-Hash SIGNED MESSAGE headers (as opposed to the SIGNATURE headers), to prevent a "Thank you!" message turning into -----BEGIN PGP SIGNED MESSAGE----- Reminder: I need you to wire $100k to 12345566 as soon as possible. Thank you! -----BEGIN PGP SIGNATURE----- [...] While at it, also check for trailing characters after the signed message delimiter, as they are invalid and can be similarly used to confuse humans. The Decode API is also unfortunate in that it doesn't return an error, so we can't tell the user what's wrong with the message, but that's what we've got. Change-Id: I8a72c4851075337443d7a27e0b49a6b6e39f5a41 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/453011 Reviewed-by: Adam Langley <agl@google.com> Reviewed-on: https://go-review.googlesource.com/c/crypto/+/173778 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-01-31all: fix ineffectual assignmentsMichael Cook
audited using ineffassign tool from github.com/gordonklaus/ineffassign go generate does not generate any changes Change-Id: Iabbec9ec1aae39081289d503d79fd7b4caadf17b GitHub-Last-Rev: acd17cce410e9c68ce3c87b5546261be9153e3ea GitHub-Pull-Request: golang/crypto#70 Reviewed-on: https://go-review.googlesource.com/c/155942 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-12-03openpgp: support SHA384Axel Wagner
SHA384 is a natural hashing choice for P-384 ECDSA. The only thing needed to make it usable, is adding it to the list of candidates. Change-Id: I61f66f371774f95dfc1de30d10fab66f92c21b6b Reviewed-on: https://go-review.googlesource.com/c/137956 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-10-29openpgp: pass hash to Signer.Sign for ECDSAAxel Wagner
Change-Id: Iabb601d9d7f3394c2a20cacd042c00bd05457500 Reviewed-on: https://go-review.googlesource.com/c/137897 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-10-29all: fix typosIgor Zhilianin
Change-Id: I62cbcfcd0be5f6a74d93b85b24ff7607533bb239 GitHub-Last-Rev: 9967869e706e9fe7d13964bb32b30a44ba640869 GitHub-Pull-Request: golang/crypto#64 Reviewed-on: https://go-review.googlesource.com/c/145240 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-10-25openpgp: don't generate PubKeyAlgoRSASignOnly keysAxel Wagner
These are deprecated according to RFC4880 and should no longer be generated: https://tools.ietf.org/html/rfc4880#section-13.5 With that, the notion of a "sign-only" private key doesn't make sense (as that is a signature property, not a private key property), so remove it from the comment. Fixes golang/go#27888 Change-Id: I7d41acd0793b2caf3c0897e580f42375c72d82a8 Reviewed-on: https://go-review.googlesource.com/c/137896 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-10-09openpgp: split up tests and keysaviau
keys_test.go was slowing down my editor because it was getting too large. It helps to remove the keys of the file as they contain extremely long lines and large strings. Change-Id: I8d193179ddc32438b7233f0f9ca8c57c928a0436 Reviewed-on: https://go-review.googlesource.com/c/138997 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-10-01openpgp: allow RSA/ECDSA signers to return a pointerAxel Wagner
Fixes golang/go#27606 Change-Id: I88b2f7c7796b43449a17a6be963c05f741dbf904 Reviewed-on: https://go-review.googlesource.com/137895 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-10-01openpgp: test subkeys with sub-optimal signature packet orderingaviau
Test for RFC4880 5.2.3.3: > An implementation that encounters multiple self-signatures on the > same object may resolve the ambiguity in any way it sees fit, but it > is RECOMMENDED that priority be given to the most recent self- > signature. Note: Some GPG implementation will reorder the packets for you when exporting keys. This makes it complicated to generate a key for this test. Should someone have to create a similar key again, look into gpgsplit, gpg --dearmor, and gpg --enarmor. These keys exist in the wild too. Change-Id: I5d46054ebbc95407d644e4e462d777aab290794c Reviewed-on: https://go-review.googlesource.com/138215 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-10-01openpgp: use latest subkey binding signaturePaul M Furley
Rather than using the first subkey binding signature encountered, use the one with the most recent creation data, as per the recommendation from RFC 4880: > An implementation that encounters multiple self-signatures on the > same object may resolve the ambiguity in any way it sees fit, but it > is RECOMMENDED that priority be given to the most recent self- > signature. This allows subkeys to approach expiry then be re-signed with a new expiry. This extends the recent commit 0e37d00 by @aviau and @FiloSottile. Fixes golang/go#26468 Change-Id: I7f12706727373259c188bfee4254306ef9d4e935 GitHub-Last-Rev: 0da814166411a3c3334312576d3f7f8f2bba4ff4 GitHub-Pull-Request: golang/crypto#57 Reviewed-on: https://go-review.googlesource.com/135357 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-09-27openpgp: move addUserID outside of ReadEntityaviau
In change id Id992676ef2363779a7028f4799180efb027fcf47, "current" was moved into the UserID packet handling scope. This was the only thing preventing us to move the UserID packet handling code inside its own function. This patch moves the UserID packet handling code inside a new addUserID function. This is consistent with the other existing addSubKey method. "current" is renamed to "identity" for improved readability. Change-Id: I5d58eb35ab5fa9fc7d9d111fa186fec6f5e11e79 Reviewed-on: https://go-review.googlesource.com/118959 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-09-10openpgp: don't treat extra subkey selfsigs as uid sigsaviau
Consider the following packet ordering scenario: PUBKEY UID SELFSIG SUBKEY REV SELFSIG In this scenario, addSubkey would only consume the REV signature after the subkey, leaving SELFSIG to be read by ReadEntity, which in turn would add the last SELFSIG to the UID's signatures, which is wrong to do because this is a SUBKEY SELFSIG, not a UID signature. Remove "current" from the ReadEntity scope, it should only be visible to the UserId packet handling code. Keep the warning about signature packets found before user id packets. Without it, I would not have found this bug. Modify addSubKey so that it consumes all signatures following the SUBKEY packet, keeping eithier the first valid signature (like we did before) or any valid revocation. In a follow-up patch, we can improve this further by keeping the most recent signature, as suggested by RFC4880: > An implementation that encounters multiple self-signatures on the > same object may resolve the ambiguity in any way it sees fit, but it > is RECOMMENDED that priority be given to the most recent self- > signature. Fixes golang/go#26449 Change-Id: Id992676ef2363779a7028f4799180efb027fcf47 Reviewed-on: https://go-review.googlesource.com/118957 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-08-16openpgp/clearsign: add ability to sign with more than one key.Thomas Bushnell, BSG
Change-Id: I34036514435d365adb2b9da4ac66673be466a34b Reviewed-on: https://go-review.googlesource.com/129655 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-07-18openpgp: support creating signatures compatible with 'gpg --sign'.Wilfried Teiken
This is neither a '--clearsign' nor a '--detach-sign' which are already supported. Verification of these signatures is already supported by ReadMessage. The code shares a lot with standard encrypt/sign, so mostly a refactoring of 'Encrypt' to allow use of the code path without actually doing a signing. Change-Id: I5bb7487134ffcf1189ed74e28dbbbe1c01b356d1 GitHub-Last-Rev: 01162222600a4a2a230a444387b33883faf596ec GitHub-Pull-Request: golang/crypto#50 Reviewed-on: https://go-review.googlesource.com/116017 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-06-14openpgp: restore signing in SerializePrivateFilippo Valsorda
Signing was moved in NewEntity as it makes more sense there, but there might be code that relies on SerializePrivate to make signatures with parameters that were modified after NewEntity. As it used to always sign in SerializePrivate, it shouldn't break anything to sign in both places. Fixes golang/go#25463 Change-Id: Ia7f509daf31ac05fedc441225d554f333b288d70 Reviewed-on: https://go-review.googlesource.com/118015 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Yaron de Leeuw <jarondl@google.com> Reviewed-by: Alexandre Viau <viau.alexandre@gmail.com> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-06-14openpgp: fix bad error messageaviau
When failing, TestKeyExpiry would output the wrong expected key id. It would output "Expected key 1ABB25A0" instead of "Expected key 96A672F5". Avoid this mistake by declaring the variable only once and using it in the error format. Change-Id: I860d82bf2c7fa80558051cdb21a41d506e95c25f Reviewed-on: https://go-review.googlesource.com/118958 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-06-14openpgp: read keys with revoked user idsaviau
The existing code was wrongly assuming that UserID packets must be immediately followed by a Signature packet. However, this is not true. See RFC4880 11.1: > Immediately following each User ID packet, there are zero or more > Signature packets. This change will ensure that Entities that are not immediately followed by a Signature packet are read without raising a StructuralError. Instead, UserID packets that are not immediately followed by a self signature will be ignored. Maximum backwards compatibility is retained because revoked UserIDs are not added to the Entity's identities. In a follow-up patch, we should probably add these UserIDs to the Entity's identities too, but not without making sure that the revocation is also available in the Entity's (or the Identity's) Revocations slice. This would require adding support for a new Signature Type, "Certification revocation signature", as defined in RFC 48880 5.2.1. Fixes golang/go#25850 Change-Id: Idde34b97429998f28e0c687171024e51ed959bf0 Reviewed-on: https://go-review.googlesource.com/118376 Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-05-23openpgp: sign Entity during instantiation in NewEntityRyan Canty
Previously if you created a new Entity then ran `Serialize` _before_ running `SerializePrivate`, the resulting armored public key was corrupted, giving the error of `unexpected EOF`. This fix signs the public key with the private key upon creation of a NewEntity. Since SerializePrivate only is applicable to entities created with NewEntity per the docs we can also safely remove the signing portion from that function. Fixes #25463 Change-Id: I58b808987ee173079f33bce3d6c3527f9233b2cd GitHub-Last-Rev: 2c4b8e4d630a06d782816f8fbd3d59f01ece2565 GitHub-Pull-Request: golang/crypto#47 Reviewed-on: https://go-review.googlesource.com/114001 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-05-09openpgp: fix vet issue in testsFilippo Valsorda
https://golang.org/cl/111416 made vet spot this new issue by recognizing the len() call as side-effect free: redundant or: md.IsSymmetricallyEncrypted || md.IsSymmetricallyEncrypted Change-Id: I8b72eedb458365a50e14d5eec35b972ee61efb1f Reviewed-on: https://go-review.googlesource.com/112255 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
2018-03-16openpgp/packet: improve handling of short MPIs for RSA valuesFilippo Valsorda
MPIs are (supposed to be) stripped of leading zeroes. Avoid passing such short values into crypto/rsa, even if it currently happens to work. Change-Id: I5a5f4813b8358e83fcc2deeda1272d2733814542 Reviewed-on: https://go-review.googlesource.com/100844 Reviewed-by: Adam Langley <agl@golang.org>
2018-03-15openpgp: serialize correct bitlength for generated ECC keysMike Tsao
Rather than rounding the `type || X || Y` byte sequence to the next 8-bit boundary, packet.NewECDSAPublicKey() now rounds the X and Y coordinates individually, then adds the bitlength 3 of type 4 (compressed). For NIST P-256, this leads to a bit length of 515, rather than 520. GnuPG calculates 515 as well, and https://tools.ietf.org/html/rfc6637#section-6 explicitly states that "the exact size of the MPI payload is 515 bits for 'Curve P-256,'" so the new formula is consistent. Fixes golang/go#23460 Change-Id: I64b340d1c761bfd795a1a64dc2f7a831c8b2ff32 Reviewed-on: https://go-review.googlesource.com/87995 Reviewed-by: Adam Langley <agl@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> Run-TryBot: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-03-15openpgp/packet: fix swallowed errors in (*EncryptedKey).parseLars Lehtonen
Change-Id: I23da7bcda044417804a4c827501437d506002e8e Reviewed-on: https://go-review.googlesource.com/63430 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
2018-02-14openpgp: allow NewEntity to specify the default cipherDamien Tournoud
The openpgp package promotes bad defaults by not setting the preferred cipher and hash of new entities created by `openpgp.NewEntity`. The preferred hash can be set by passing a `packet.Config` with a `DefaultHash` set, but the same cannot be done for the preferred cipher. This change copies the DefaultCipher into the self-signature, similar to DefaultHash. Change-Id: I80e1289d67b7cd4079be8c1d5ba603a555dbe5c1 Reviewed-on: https://go-review.googlesource.com/66430 Run-TryBot: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Adam Langley <agl@golang.org>
2018-02-13openpgp: correct NewEntity name creationYaron de Leeuw
Confusingly, `Identity.Name` should actually refer to `uid.Id` and not `uid.Name`. This fixes the code in NewEntity, and creates a test case to verify. Change-Id: Id46de876fc7b0359faecfeb9b09a8e454710d485 Reviewed-on: https://go-review.googlesource.com/92595 Reviewed-by: Adam Langley <agl@golang.org>
2017-11-28all: fix errors reported by vet, golintKevin Burke
None are "wrong" per se, but there are a lot of good suggestions and in one case a docstring that was not present in godoc due to the presence of an extra newline. Changed "Id" in struct properties to "ID" in some non-exported structs. Removed a trailing period from some error messages; I believe the exact contents of error strings are not covered by the Go compatibility promise. Change-Id: I7c620582dc247396f72c52d38c909ccc0ec87b83 Reviewed-on: https://go-review.googlesource.com/80145 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2017-09-15all: fix article typosnamusyaka
a -> an Change-Id: I95a940df64cb825887b75a80eadc822095b49781 Reviewed-on: https://go-review.googlesource.com/63991 Run-TryBot: Alex Vaghin <ddos@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Vaghin <ddos@google.com>
2017-09-09openpgp: check errors from ReadKeyRing during testRuss Cox
Otherwise if ReadKeyRing is buggy the errors point elsewhere. Change-Id: Id2df4b6763ddf93fad5a9824f94af426bf0b7700 Reviewed-on: https://go-review.googlesource.com/62153 Reviewed-by: Adam Langley <agl@golang.org>
2017-08-03openpgp/packet: fix AES-192 encrypted session keysmdp
The existing implementation checks to see if the session key size is a multiple of the cipher blocksize. This fails for AES-192, which has a keysize of 24 bytes and a 16 byte block size. Instead it should simply check to ensure that the Session Key length is equal to the cipher KeySize. Fixes golang/go#17060 Change-Id: I1dc78129f7fb2ca5ec71b650a2adcb3752dca885 Reviewed-on: https://go-review.googlesource.com/35848 Reviewed-by: Adam Langley <agl@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2017-01-04all: fix some vet warningsJoe Tsai
Change-Id: I85c2912a6862c6c251450f2a0926ecd33a9fb8e7 Reviewed-on: https://go-review.googlesource.com/34815 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-10-04x/crypto/openpgp: support crypto.Signer private keysSamuele Pedroni
This adds support for crypto.Signer-based RSA and ECDSA private keys. This enables using opaque signing keys as explained in the documentation for crypto.Signer. The support is in the form of a new NewSignerPrivateKey function which makes a PrivateKey from a crypto.Signer. Fixes golang/go#15841. Change-Id: Ice2ec2793a9f5409a5bfd4e5e49d919e14ede1e0 Reviewed-on: https://go-review.googlesource.com/23802 Run-TryBot: Adam Langley <agl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Adam Langley <agl@golang.org>
2016-09-28openpgp: fix a typo in a commentAlok Menghrajani
Change-Id: I9fe23643ae644c4cc4a36b14ad6efe99197c8beb Reviewed-on: https://go-review.googlesource.com/29959 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-09-13opengpg: set SelfSignature.PreferredHash in NewEntityJessica Frazelle
Say the user wants to create a NewEntity, then Serialize the private and public keys. Then call Encrypt. The Hash used first for Encrypt will be `RIPEMD160`, which is not compiled in by default. So say they _specifically_ pass crypto.SHA256 as the Default hash to NewEntity, this should set the PreferredHash in the SelfSignature so they can be encrypted with that hash. Related to golang/go#12153 Change-Id: I3d89f9d60f9abb29ec8365f81da38b8cd0594587 Reviewed-on: https://go-review.googlesource.com/23209 Reviewed-by: Adam Langley <agl@golang.org>
2016-09-08crypto/openpgp: return error from userIdSignatureHashReinaldo de Souza Jr
Signature#SignUserId was ignoring the error returned by userIdSignatureHash. This error can happen, for example, when the Signature's Hash property is uninitialized. Not returning the error makes it hard for the user to detect the problem. Change-Id: I0ae0033e77bfb1ea1c06b0769f949e48c713adc6 Reviewed-on: https://go-review.googlesource.com/27997 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 06:13:27 +0000