diff options
| author | Bryan C. Mills <bcmills@google.com> | 2024-01-05 18:21:50 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-01-08 16:44:29 +0000 |
| commit | dbb6ec16ecef7a66638d8514be54b13660551b0a (patch) | |
| tree | 166ea83dc8d6154b44a0f5349ce10289b517d11e /ssh/test/forward_unix_test.go | |
| parent | 403f69900ed17a8c7dace8740fa0bed65ad19bbf (diff) | |
| download | go-x-crypto-0.18.0.tar.xz | |
ssh/test: skip tests on darwin that fail on the darwin-amd64-longtest LUCI builderv0.18.0
We don't yet understand why these tests fail, but the Apple sshd seems
to have some non-trivial vendor patches, so it is plausibly a
platform-specific bug in the test. Let's skip that failure mode on the
whole platform until/unless someone has time to reproduce and
investigate the failure.
For golang/go#64959.
Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-darwin-amd64-longtest,x_crypto-gotip-linux-amd64-longtest,x_crypto-gotip-windows-amd64-longtest
Change-Id: I9e43579469de3fe9329c093b5916bbed0edd3751
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/554077
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'ssh/test/forward_unix_test.go')
| -rw-r--r-- | ssh/test/forward_unix_test.go | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/ssh/test/forward_unix_test.go b/ssh/test/forward_unix_test.go index 611122b..e32d732 100644 --- a/ssh/test/forward_unix_test.go +++ b/ssh/test/forward_unix_test.go @@ -12,6 +12,7 @@ import ( "io" "math/rand" "net" + "runtime" "testing" "time" ) @@ -27,6 +28,9 @@ func testPortForward(t *testing.T, n, listenAddr string) { sshListener, err := conn.Listen(n, listenAddr) if err != nil { + if runtime.GOOS == "darwin" && err == io.EOF { + t.Skipf("skipping test broken on some versions of macOS; see https://go.dev/issue/64959") + } t.Fatal(err) } @@ -122,6 +126,9 @@ func testAcceptClose(t *testing.T, n, listenAddr string) { sshListener, err := conn.Listen(n, listenAddr) if err != nil { + if runtime.GOOS == "darwin" && err == io.EOF { + t.Skipf("skipping test broken on some versions of macOS; see https://go.dev/issue/64959") + } t.Fatal(err) } @@ -163,6 +170,9 @@ func testPortForwardConnectionClose(t *testing.T, n, listenAddr string) { sshListener, err := client.Listen(n, listenAddr) if err != nil { + if runtime.GOOS == "darwin" && err == io.EOF { + t.Skipf("skipping test broken on some versions of macOS; see https://go.dev/issue/64959") + } t.Fatal(err) } |