diff options
| author | Michael Stapelberg <stapelberg@golang.org> | 2025-12-02 14:40:57 +0100 |
|---|---|---|
| committer | Michael Stapelberg <stapelberg@golang.org> | 2025-12-02 08:08:01 -0800 |
| commit | f4602e40409257658159002a9af6aedb875949fb (patch) | |
| tree | 4d7f33b8ae1b85b6df8ee84c21cda2c201d4acfc | |
| parent | 4e0068c0098be10d7025c99ab7c50ce454c1f0f9 (diff) | |
| download | go-x-crypto-f4602e40409257658159002a9af6aedb875949fb.tar.xz | |
ssh/agent: fix flaky test by ensuring a writeable home directory
This fixes flakiness observed inside Google (b/465393996).
Change-Id: Ic3decc3206b470cddf22c441b0cf92bb2bebb075
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/724002
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
| -rw-r--r-- | ssh/agent/client_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ssh/agent/client_test.go b/ssh/agent/client_test.go index 0fd284d..2ca92a4 100644 --- a/ssh/agent/client_test.go +++ b/ssh/agent/client_test.go @@ -40,7 +40,11 @@ func startOpenSSHAgent(t *testing.T) (client ExtendedAgent, socket string, clean } cmd := exec.Command(bin, "-s") - cmd.Env = []string{} // Do not let the user's environment influence ssh-agent behavior. + cmd.Env = []string{ + // ssh-agent creates ~/.ssh and ~/.ssh/agent; + // ensure a writeable home directory. + "HOME=" + t.TempDir(), + } // Do not let the user's environment influence ssh-agent behavior. cmd.Stderr = new(bytes.Buffer) out, err := cmd.Output() if err != nil { |