From f4602e40409257658159002a9af6aedb875949fb Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Tue, 2 Dec 2025 14:40:57 +0100 Subject: ssh/agent: fix flaky test by ensuring a writeable home directory This fixes flakiness observed inside Google (b/465393996). Change-Id: Ic3decc3206b470cddf22c441b0cf92bb2bebb075 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/724002 Reviewed-by: Roland Shoemaker LUCI-TryBot-Result: Go LUCI --- ssh/agent/client_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ssh/agent/client_test.go b/ssh/agent/client_test.go index 0fd284d..2ca92a4 100644 --- a/ssh/agent/client_test.go +++ b/ssh/agent/client_test.go @@ -40,7 +40,11 @@ func startOpenSSHAgent(t *testing.T) (client ExtendedAgent, socket string, clean } cmd := exec.Command(bin, "-s") - cmd.Env = []string{} // Do not let the user's environment influence ssh-agent behavior. + cmd.Env = []string{ + // ssh-agent creates ~/.ssh and ~/.ssh/agent; + // ensure a writeable home directory. + "HOME=" + t.TempDir(), + } // Do not let the user's environment influence ssh-agent behavior. cmd.Stderr = new(bytes.Buffer) out, err := cmd.Output() if err != nil { -- cgit v1.3