diff options
| author | Daniel McCarney <daniel@binaryparadox.net> | 2025-08-06 12:43:58 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-08-06 13:33:03 -0700 |
| commit | b999374650442ee37e9bbd97d6a11ad7ed999b98 (patch) | |
| tree | fe345282467d59f1e1022685f2e073169adca7df | |
| parent | c247dead11de7671a21a6c5169555e2aa5313caa (diff) | |
| download | go-x-crypto-b999374650442ee37e9bbd97d6a11ad7ed999b98.tar.xz | |
acme: fix pebble subprocess output data race
Wait for process completion before reading stdout/stderr buffers
to eliminate race between I/O Go routines and test cleanup.
Updates golang/go#74437
Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-linux-amd64-longtest-race
Change-Id: I2e650c04db5be0d7a1e858ce40e25f13ad12223c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/693596
Auto-Submit: Daniel McCarney <daniel@binaryparadox.net>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
| -rw-r--r-- | acme/pebble_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/acme/pebble_test.go b/acme/pebble_test.go index e373849..b633435 100644 --- a/acme/pebble_test.go +++ b/acme/pebble_test.go @@ -789,6 +789,7 @@ func spawnServerProcess(t *testing.T, dir string, cmd string, args ...string) { t.Cleanup(func() { cmdInstance.Process.Kill() + cmdInstance.Wait() if t.Failed() || testing.Verbose() { t.Logf("=== %s output ===", cmd) |