From b999374650442ee37e9bbd97d6a11ad7ed999b98 Mon Sep 17 00:00:00 2001 From: Daniel McCarney Date: Wed, 6 Aug 2025 12:43:58 -0400 Subject: acme: fix pebble subprocess output data race Wait for process completion before reading stdout/stderr buffers to eliminate race between I/O Go routines and test cleanup. Updates golang/go#74437 Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-linux-amd64-longtest-race Change-Id: I2e650c04db5be0d7a1e858ce40e25f13ad12223c Reviewed-on: https://go-review.googlesource.com/c/crypto/+/693596 Auto-Submit: Daniel McCarney Reviewed-by: Roland Shoemaker Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI --- acme/pebble_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/acme/pebble_test.go b/acme/pebble_test.go index e373849..b633435 100644 --- a/acme/pebble_test.go +++ b/acme/pebble_test.go @@ -789,6 +789,7 @@ func spawnServerProcess(t *testing.T, dir string, cmd string, args ...string) { t.Cleanup(func() { cmdInstance.Process.Kill() + cmdInstance.Wait() if t.Failed() || testing.Verbose() { t.Logf("=== %s output ===", cmd) -- cgit v1.3