diff options
| author | Patrick Steinhardt <ps@pks.im> | 2026-03-19 06:33:21 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-19 06:40:08 -0700 |
| commit | 8ca1b4472ce97ae1d120608f9f02a86fa33d4187 (patch) | |
| tree | 08c593382b995fb479d6f883db59ee7c175e2e0c /tools/coccinelle/commit.cocci | |
| parent | 8872941fd21e2afe37032e7d9beec87b69aca9c9 (diff) | |
| download | git-8ca1b4472ce97ae1d120608f9f02a86fa33d4187.tar.xz | |
contrib: move "coccinelle/" directory into "tools/"
The Coccinelle tool is an ingrained part of our build infrastructure. It
is executed by our CI to detect antipatterns and is used to detect
misuses of certain interfaces. It's presence in "contrib/" is thus
rather misleading.
Promote the configuration into the new "tools/" directory.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'tools/coccinelle/commit.cocci')
| -rw-r--r-- | tools/coccinelle/commit.cocci | 53 |
1 files changed, 53 insertions, 0 deletions
diff --git a/tools/coccinelle/commit.cocci b/tools/coccinelle/commit.cocci new file mode 100644 index 0000000000..42725161e9 --- /dev/null +++ b/tools/coccinelle/commit.cocci @@ -0,0 +1,53 @@ +@@ +expression c; +@@ +- &c->maybe_tree->object.oid ++ get_commit_tree_oid(c) + +@@ +expression c; +@@ +- c->maybe_tree->object.oid.hash ++ get_commit_tree_oid(c)->hash + +@@ +identifier f !~ "^set_commit_tree$"; +expression c; +expression s; +@@ + f(...) {<... +- c->maybe_tree = s ++ set_commit_tree(c, s) + ...>} + +// These excluded functions must access c->maybe_tree directly. +// Note that if c->maybe_tree is written somewhere outside of these +// functions, then the recommended transformation will be bogus with +// repo_get_commit_tree() on the LHS. +@@ +identifier f != { repo_get_commit_tree, get_commit_tree_in_graph_one, + load_tree_for_commit, set_commit_tree, repo_parse_commit_no_graph }; +expression c; +@@ + f(...) {<... +- c->maybe_tree ++ repo_get_commit_tree(specify_the_right_repo_here, c) + ...>} + +@@ +struct commit *c; +expression E; +@@ +( +- c->generation = E; ++ commit_graph_data_at(c)->generation = E; +| +- c->graph_pos = E; ++ commit_graph_data_at(c)->graph_pos = E; +| +- c->generation ++ commit_graph_generation(c) +| +- c->graph_pos ++ commit_graph_position(c) +) |