diff options
| author | Derrick Stolee <stolee@gmail.com> | 2026-02-23 12:26:50 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-02-23 13:23:41 -0800 |
| commit | bcfb9128c9ce87dfeacaffe051257f7a5fc866e9 (patch) | |
| tree | c8c4495dba070a542dc7eee85c1cfc62d14ddc57 /t | |
| parent | 9c7fc23c24cc0cfeaf5fe32a96fbfe2709a3f93d (diff) | |
| download | git-bcfb9128c9ce87dfeacaffe051257f7a5fc866e9.tar.xz | |
config: format paths gently
Move the logic for formatting path config values into a helper method
and use gentle parsing when needed.
We need to be careful about how to handle the ':(optional)' macro, which
as tested in t1311-config-optional.sh must allow for ignoring a missing
path when other multiple values exist, but cause 'git config get' to
fail if it is the only possible value and thus no result is output.
In the case of our list, we need to omit those values silently. This
necessitates the use of the 'gently' parameter here.
Signed-off-by: Derrick Stolee <stolee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t1300-config.sh | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 1fc8e788ee..48d9c554d8 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -2545,7 +2545,6 @@ test_expect_success 'list --type=bool-or-int shows only canonicalizable values' ' test_expect_success 'list --type=path shows only canonicalizable path values' ' - # TODO: handling of missing path is incorrect here. cat >expect <<-EOF && section.foo=True section.number=10 @@ -2554,7 +2553,7 @@ test_expect_success 'list --type=path shows only canonicalizable path values' ' section.red=red section.blue=Blue section.date=Fri Jun 4 15:46:55 2010 - section.missing=section.exists=expect + section.exists=expect EOF git config ${mode_prefix}list --type=path >actual 2>err && |