diff options
| author | Jonatan Holmgren <jonatan@jontes.page> | 2026-02-18 22:57:34 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-02-19 10:13:20 -0800 |
| commit | 3f0cdfa87907096ed7c6caa33fbf360e0e19844c (patch) | |
| tree | 5ac17d0142dc29ed0af1728149d229d04da9b372 /t | |
| parent | 67ad42147a7acc2af6074753ebd03d904476118f (diff) | |
| download | git-3f0cdfa87907096ed7c6caa33fbf360e0e19844c.tar.xz | |
help: use list_aliases() for alias listing
help.c has its own get_alias() config callback that duplicates the
parsing logic in alias.c. Consolidate by teaching list_aliases() to
also store the alias values (via the string_list util field), then
use it in list_all_cmds_help_aliases() instead of the private
callback.
This preserves the existing error checking for value-less alias
definitions by checking in alias.c rather than help.c.
No functional change intended.
Signed-off-by: Jonatan Holmgren <jonatan@jontes.page>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t0014-alias.sh | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh index 07a53e7366..a13d2be8ca 100755 --- a/t/t0014-alias.sh +++ b/t/t0014-alias.sh @@ -112,4 +112,14 @@ test_expect_success 'cannot alias-shadow a sample of regular builtins' ' done ' +test_expect_success 'alias without value reports error' ' + test_when_finished "git config --unset alias.noval" && + cat >>.git/config <<-\EOF && + [alias] + noval + EOF + test_must_fail git noval 2>error && + test_grep "alias.noval" error +' + test_done |