diff options
| author | Patrick Steinhardt <ps@pks.im> | 2026-03-12 09:43:01 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-12 08:38:43 -0700 |
| commit | 6801ffd37df8420917e1feaf03b5f7c175798bff (patch) | |
| tree | 07c19a65d1974eed84639ed1b5682aae2491f8c3 /packfile.c | |
| parent | b259f2175b0ccd5574fc6b06b8ec5cbeaa860610 (diff) | |
| download | git-6801ffd37df8420917e1feaf03b5f7c175798bff.tar.xz | |
odb: introduce generic object counting
Similar to the preceding commit, introduce counting of objects on the
object database level, replacing the logic that we have in
`repo_approximate_object_count()`.
Note that the function knows to cache the object count. It's unclear
whether this cache is really required as we shouldn't have that many
cases where we count objects repeatedly. But to be on the safe side the
caching mechanism is retained, with the only excepting being that we
also have to use the passed flags as caching key.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'packfile.c')
| -rw-r--r-- | packfile.c | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/packfile.c b/packfile.c index 8ee462303a..d4de9f3ffe 100644 --- a/packfile.c +++ b/packfile.c @@ -1132,33 +1132,6 @@ out: return ret; } -/* - * Give a fast, rough count of the number of objects in the repository. This - * ignores loose objects completely. If you have a lot of them, then either - * you should repack because your performance will be awful, or they are - * all unreachable objects about to be pruned, in which case they're not really - * interesting as a measure of repo size in the first place. - */ -unsigned long repo_approximate_object_count(struct repository *r) -{ - if (!r->objects->approximate_object_count_valid) { - struct odb_source *source; - unsigned long count = 0; - - odb_prepare_alternates(r->objects); - for (source = r->objects->sources; source; source = source->next) { - unsigned long c; - - if (!odb_source_count_objects(source, ODB_COUNT_OBJECTS_APPROXIMATE, &c)) - count += c; - } - - r->objects->approximate_object_count = count; - r->objects->approximate_object_count_valid = 1; - } - return r->objects->approximate_object_count; -} - unsigned long unpack_object_header_buffer(const unsigned char *buf, unsigned long len, enum object_type *type, unsigned long *sizep) { |