diff options
| author | Taylor Blau <me@ttaylorr.com> | 2026-02-24 13:59:44 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-02-24 11:16:32 -0800 |
| commit | 6e86f679248580bec5c105b37217862f3022b504 (patch) | |
| tree | 75e780d855857c2cfaf7e265ef0200b7d952fe0f /pack-bitmap.c | |
| parent | de811c26bb97ac324b60883ae4f4db84a83be2f1 (diff) | |
| download | git-6e86f679248580bec5c105b37217862f3022b504.tar.xz | |
midx: introduce `midx_get_checksum_hex()`
When trying to print out, say, the hexadecimal representation of a
MIDX's hash, our code will do something like:
hash_to_hex_algop(midx_get_checksum_hash(m),
m->source->odb->repo->hash_algo);
, which is both cumbersome and repetitive. In fact, all but a handful of
callers to `midx_get_checksum_hash()` do exactly the above. Reduce the
repetitive nature of calling `midx_get_checksum_hash()` by having it
return a pointer into a static buffer containing the above result.
For the handful of callers that do need to compare the raw bytes and
don't want to deal with an encoded copy (e.g., because they are passing
it to hasheq() or similar), they may still rely on
`midx_get_checksum_hash()` which returns the raw bytes.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-bitmap.c')
| -rw-r--r-- | pack-bitmap.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/pack-bitmap.c b/pack-bitmap.c index 6307bbdf1e..afc7fba019 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -2819,8 +2819,7 @@ void test_bitmap_walk(struct rev_info *revs) if (bitmap_is_midx(found)) fprintf_ln(stderr, "Located via MIDX '%s'.", - hash_to_hex_algop(midx_get_checksum_hash(found->midx), - revs->repo->hash_algo)); + midx_get_checksum_hex(found->midx)); else fprintf_ln(stderr, "Located via pack '%s'.", hash_to_hex_algop(found->pack->hash, |