diff options
| author | Tian Yuchen <cat@malon.dev> | 2026-03-09 14:51:40 +0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-09 12:45:19 -0700 |
| commit | 4c223571bef1c008c11ad5028072af862d3e7fe3 (patch) | |
| tree | c02ecea7100fc75a95847a400038d56fc0621c0f /fetch-pack.c | |
| parent | 9a2fb147f2c61d0cab52c883e7e26f5b7948e3ed (diff) | |
| download | git-4c223571bef1c008c11ad5028072af862d3e7fe3.tar.xz | |
patch-ids: document intentional const-casting in patch_id_neq()
The hashmap API requires the comparison function to take const pointers.
However, patch_id_neq() uses lazy evaluation to compute patch IDs on
demand. As established in b3dfeebb (rebase: avoid computing unnecessary
patch IDs, 2016-07-29), this avoids unnecessary work since not all
objects in the hashmap will eventually be compared.
Remove the ten-year-old "NEEDSWORK" comment and formally document
this intentional design trade-off.
Signed-off-by: Tian Yuchen <cat@malon.dev>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fetch-pack.c')
0 files changed, 0 insertions, 0 deletions