diff options
| author | Moritz Baumann <moritz.baumann@sap.com> | 2022-07-20 18:55:30 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-07-20 13:53:54 -0700 |
| commit | 198551ca54f6ff1c95c9357ccca9ae37298811bf (patch) | |
| tree | 51751dbca30e7340d1f52557befe79233bc2b498 /Documentation/git-commit-graph.txt | |
| parent | c0d2b07460ab9e42ac398316544ed3eb43f9a998 (diff) | |
| download | git-198551ca54f6ff1c95c9357ccca9ae37298811bf.tar.xz | |
git-p4: fix error handling in P4Unshelve.renameBranch()
The error handling code path is meant to be triggered when the loop does
not exit early via "break". This fails, as the boolean variable "found",
which is used to track whether the loop was exited early, is initialized
incorrectly.
It would be possible to fix this issue by correcting the initialization,
but Python supports a for:-else: control flow construct for this exact
use case (executing code if a loop does not exit early), so it is more
idiomatic to remove the tracking variable entirely.
In addition, the error message no longer refers to a variable that does
not exist.
Signed-off-by: Moritz Baumann <moritz.baumann@sap.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-commit-graph.txt')
0 files changed, 0 insertions, 0 deletions