diff options
| author | Junio C Hamano <junkio@cox.net> | 2007-05-21 20:03:53 -0700 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2007-05-21 20:03:53 -0700 |
| commit | fbf5df024e9137d446c5a85adeae7e4780365d1b (patch) | |
| tree | 69e649ccbf7f457673d2f401956f54b20a7b5f2f /Documentation/SubmittingPatches | |
| parent | 93d496a560cdcd4f72c8dee1b0b2efa324e1c3bb (diff) | |
| parent | 523d12e5003eee0c2cb670b51e39d719cd56aacd (diff) | |
| download | git-fbf5df024e9137d446c5a85adeae7e4780365d1b.tar.xz | |
Merge branch 'maint'
* maint:
git-cvsserver: fix disabling service via per-method config
git-status: respect core.excludesFile
SubmittingPatches: mention older C compiler compatibility
git-daemon: don't ignore pid-file write failure
Diffstat (limited to 'Documentation/SubmittingPatches')
| -rw-r--r-- | Documentation/SubmittingPatches | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 6a4da2ddd9..b94d9a8166 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -65,6 +65,19 @@ in templates/hooks--pre-commit. To help ensure this does not happen, run git diff --check on your changes before you commit. +(1a) Try to be nice to older C compilers + +We try to support wide range of C compilers to compile +git with. That means that you should not use C99 initializers, even +if a lot of compilers grok it. + +Also, variables have to be declared at the beginning of the block +(you can check this with gcc, using the -Wdeclaration-after-statement +option). + +Another thing: NULL pointers shall be written as NULL, not as 0. + + (2) Generate your patch using git tools out of your commits. git based diff tools (git, Cogito, and StGIT included) generate |