diff options
| author | Patrick Steinhardt <ps@pks.im> | 2026-03-02 13:13:06 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-03 15:09:35 -0800 |
| commit | e3d4d7787cc3b2f0281e808042ceaa08e05c281b (patch) | |
| tree | 040acc1ed301c750b52ee06c4e8b1259579af153 /Documentation/RelNotes | |
| parent | 6e4d923267ca80dd1392bf7e0673c74711e8cb68 (diff) | |
| download | git-e3d4d7787cc3b2f0281e808042ceaa08e05c281b.tar.xz | |
add-patch: split out `struct interactive_options`
The `struct add_p_opt` is reused both by our infra for "git add -p" and
"git add -i". Users of `run_add_i()` for example are expected to pass
`struct add_p_opt`. This is somewhat confusing and raises the question
of which options apply to what part of the stack.
But things are even more confusing than that: while callers are expected
to pass in `struct add_p_opt`, these options ultimately get used to
initialize a `struct add_i_state` that is used by both subsystems. So we
are basically going full circle here.
Refactor the code and split out a new `struct interactive_options` that
hosts common options used by both. These options are then applied to a
`struct interactive_config` that hosts common configuration.
This refactoring doesn't yet fully detangle the two subsystems from one
another, as we still end up calling `init_add_i_state()` in the "git add
-p" subsystem. This will be fixed in a subsequent commit.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/RelNotes')
0 files changed, 0 insertions, 0 deletions
