diff options
| author | cuiweixie <cuiweixie@gmail.com> | 2026-02-25 02:00:57 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-02-25 09:12:31 -0800 |
| commit | f87593ab1a7040f4a132787ee436f67cef3136d0 (patch) | |
| tree | 30af19096b9a8c3019a6cc2c840e4f339e550ad3 | |
| parent | f368df439b31b422169975cc3c95f7db6a46eada (diff) | |
| download | git-f87593ab1a7040f4a132787ee436f67cef3136d0.tar.xz | |
fetch: fix wrong evaluation order in URL trailing-slash trimming
if i == -1, url[i] will be UB.
Signed-off-by: cuiweixie <cuiweixie@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/fetch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index 40a0e8d244..1ced5f22de 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref * display_state->url = xstrdup("foreign"); display_state->url_len = strlen(display_state->url); - for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--) + for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--) ; display_state->url_len = i + 1; if (4 < i && !strncmp(".git", display_state->url + i - 3, 4)) |