diff options
| author | Siddharth Shrimali <r.siddharth.shrimali@gmail.com> | 2026-03-05 18:24:08 +0530 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-05 11:36:43 -0800 |
| commit | 63c00a677b2b44e0691919b36a417cee648d890d (patch) | |
| tree | d0a3c7917cfbbf3c89ad4806b2b6083710a929ab | |
| parent | 67ad42147a7acc2af6074753ebd03d904476118f (diff) | |
| download | git-63c00a677b2b44e0691919b36a417cee648d890d.tar.xz | |
t9123: use test_when_finished for cleanup
Move the setup logic into a 'test_expect_success' block.
This ensures that the code is properly tracked by the test harness.
Additionally, we use the 'test_when_finished' helper at the start of
the block to ensure that the 'import' directory is removed even if the
test fails.
This is cleaner than the previous manual 'rm -rf import' approach.
Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9123-git-svn-rebuild-with-rewriteroot.sh | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/t/t9123-git-svn-rebuild-with-rewriteroot.sh b/t/t9123-git-svn-rebuild-with-rewriteroot.sh index ead404589e..8fa5940abe 100755 --- a/t/t9123-git-svn-rebuild-with-rewriteroot.sh +++ b/t/t9123-git-svn-rebuild-with-rewriteroot.sh @@ -7,12 +7,15 @@ test_description='git svn respects rewriteRoot during rebuild' . ./lib-git-svn.sh -mkdir import -(cd import - touch foo - svn_cmd import -m 'import for git svn' . "$svnrepo" >/dev/null -) -rm -rf import +test_expect_success 'setup svn repository' ' + test_when_finished "rm -rf import" && + mkdir import && + ( + cd import && + touch foo && + svn_cmd import -m "import for git svn" . "$svnrepo" >/dev/null + ) + ' test_expect_success 'init, fetch and checkout repository' ' git svn init --rewrite-root=http://invalid.invalid/ "$svnrepo" && |