diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@gmx.de> | 2023-09-12 12:55:41 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-09-12 17:32:09 -0700 |
| commit | 63642d58b4b28c3caba6d5ab0c3aa98c4ce54eaa (patch) | |
| tree | fbdf62b228c693fe55074b44aad7d9356fa95b5b | |
| parent | 43c8a30d150ecede9709c1f2527c8fba92c65f40 (diff) | |
| download | git-63642d58b4b28c3caba6d5ab0c3aa98c4ce54eaa.tar.xz | |
sequencer: remove unreachable exit condition in pick_commits()
This was introduced by 56dc3ab04 ("sequencer (rebase -i): implement the
'edit' command", 2017-01-02), and was pointless from the get-go: all
early exits from the loop above are returns, so todo_list->current ==
todo_list->nr is an invariant after the loop.
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | sequencer.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sequencer.c b/sequencer.c index 5e0c15a16b..07a8ae75b0 100644 --- a/sequencer.c +++ b/sequencer.c @@ -4823,10 +4823,6 @@ static int pick_commits(struct repository *r, struct strbuf head_ref = STRBUF_INIT, buf = STRBUF_INIT; struct stat st; - /* Stopped in the middle, as planned? */ - if (todo_list->current < todo_list->nr) - return 0; - if (read_oneliner(&head_ref, rebase_path_head_name(), 0) && starts_with(head_ref.buf, "refs/")) { const char *msg; |