diff options
| author | Jeff King <peff@peff.net> | 2026-03-23 02:02:05 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-03-23 07:42:26 -0700 |
| commit | 05002f60565cdfe2b86108c7f7c027a41d534140 (patch) | |
| tree | 1b9631d4a6cc7b83923fcd4dcad626f5700bccbf | |
| parent | 550097a645348426a3e5944d0457925381ff8e23 (diff) | |
| download | git-05002f60565cdfe2b86108c7f7c027a41d534140.tar.xz | |
diff-highlight: check diff-highlight exit status in tests
When testing diff-highlight, we pipe the output through a sanitizing
function. This loses the exit status of diff-highlight itself, which
could mean we are missing cases where it crashes or exits unexpectedly.
Use an extra tempfile to avoid the pipe.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/diff-highlight/t/t9400-diff-highlight.sh | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh index 2a9b68cf3b..7ebff8b18f 100755 --- a/contrib/diff-highlight/t/t9400-diff-highlight.sh +++ b/contrib/diff-highlight/t/t9400-diff-highlight.sh @@ -41,8 +41,10 @@ dh_test () { git show >commit.raw } >/dev/null && - "$DIFF_HIGHLIGHT" <diff.raw | test_strip_patch_header >diff.act && - "$DIFF_HIGHLIGHT" <commit.raw | test_strip_patch_header >commit.act && + "$DIFF_HIGHLIGHT" <diff.raw >diff.hi && + test_strip_patch_header <diff.hi >diff.act && + "$DIFF_HIGHLIGHT" <commit.raw >commit.hi && + test_strip_patch_header <commit.hi >commit.act && test_cmp patch.exp diff.act && test_cmp patch.exp commit.act } |