aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShulhan <ms@kilabit.info>2021-10-06 22:45:04 +0700
committerShulhan <ms@kilabit.info>2022-02-08 12:57:16 +0700
commitc857d54a1f99cf8dc829b3ff4c395c831e9016eb (patch)
tree5c13621b65a977939abe90c1c2f4968c875d63e9
parent4c53a8c20f8984adb226293a3ffd7b88c3f4ac1a (diff)
downloadgitk-resize-error.tar.xz
gitk: fix error when resizing gitkgitk-resize-error
When using gitk run on Wayland (in this case using sway window manager) and the window is vertical split, trying to resize the split will thrown the following error, expected integer but got "" expected integer but got "" while executing "$win sash place 0 $sash0 [lindex $s0 1]" (procedure "resizeclistpanes" line 38) invoked from within "resizeclistpanes .tf.histframe.pwclist 983" (command bound to event) The issue is confirmed by Anders Kaseorg on the list [1]. This commit fix this issue by checking if the $s0 or $s1 is empty string, if its true set it to 0. PS: I have send this patch to paulus@ozlabs.org, and it seems like there is no reply since 7 Oct. Either the email is not received or somethings in between. [1] https://public-inbox.org/git/1f6e179c-d9c3-e503-3218-0acf4ff27cca@mit.edu/ Signed-off-by: Shulhan <ms@kilabit.info>
-rwxr-xr-xgitk-git/gitk12
1 files changed, 10 insertions, 2 deletions
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 23d9dd1fe0..fc2add49b4 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2989,8 +2989,16 @@ proc resizeclistpanes {win w} {
$win sashpos 0 $sash0
$win sashpos 1 $sash1
} else {
- $win sash place 0 $sash0 [lindex $s0 1]
- $win sash place 1 $sash1 [lindex $s1 1]
+ set p0 [lindex $s0 1]
+ set p1 [lindex $s1 1]
+ if {$p0 eq ""} {
+ set p0 0
+ }
+ if {$p1 eq ""} {
+ set p1 0
+ }
+ $win sash place 0 $sash0 $p0
+ $win sash place 1 $sash1 $p1
}
set oldsash($win) [list $sash0 $sash1]
}