diff options
| author | Christian Barcenas <christian@cbarcenas.com> | 2025-08-21 14:46:33 -0500 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2026-02-24 00:39:05 +0100 |
| commit | 11a6c92def985710eca79733f136b471d474b053 (patch) | |
| tree | 84c5cdfd11d9edbf620c209d8e1d08c3501cb9f4 | |
| parent | e9beaff4018c02f5c46987f8b2a2e904eba28ac4 (diff) | |
| download | cgit-11a6c92def985710eca79733f136b471d474b053.tar.xz | |
ui-shared: don't write <link> if favicon unset
Since the favicon setting defaults to "/favicon.ico", the user can
only unset it with favicon=. However, that would write an empty string
as the config value. Previously, such empty string always satisfied
the if condition. In this case it is better to omit the <link> entirely.
Signed-off-by: Christian Barcenas <christian@cbarcenas.com>
Signed-off-by: Christian Hesse <mail@eworm.de>
| -rw-r--r-- | ui-shared.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-shared.c b/ui-shared.c index 838170a..7f2d566 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -832,7 +832,7 @@ void cgit_print_docstart(void) else emit_js_link(NULL, "/cgit.js"); - if (ctx.cfg.favicon) { + if (ctx.cfg.favicon && *ctx.cfg.favicon) { html("<link rel='shortcut icon' href='"); html_attr(ctx.cfg.favicon); html("'/>\n"); |