From 7048c8cc4a821a7b6d99f3ef8ff5da3dc69dd62e Mon Sep 17 00:00:00 2001 From: mitermayer Date: Wed, 2 May 2018 22:33:06 -0700 Subject: Refactoring executable resolver out into its own module - Refactoring the executable resolver into its own module for making it easier to test --- autoload/prettier/resolver/executable.vim | 74 +++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 autoload/prettier/resolver/executable.vim (limited to 'autoload/prettier/resolver') diff --git a/autoload/prettier/resolver/executable.vim b/autoload/prettier/resolver/executable.vim new file mode 100644 index 0000000..8d233ab --- /dev/null +++ b/autoload/prettier/resolver/executable.vim @@ -0,0 +1,74 @@ +let s:ROOT_DIR = fnamemodify(resolve(expand(':p')), ':h') + +" By default we will search for the following +" => user defined prettier cli path from vim configuration file +" => locally installed prettier inside node_modules on any parent folder +" => globally installed prettier +" => vim-prettier prettier installation +" => if all fails suggest install +function! prettier#resolver#executable#getPath() abort + let l:user_defined_exec_path = fnamemodify(g:prettier#exec_cmd_path, ':p') + if executable(l:user_defined_exec_path) + return l:user_defined_exec_path + endif + + let l:localExec = s:ResolveExecutable(getcwd()) + if executable(l:localExec) + return fnameescape(l:localExec) + endif + + let l:globalExec = s:ResolveExecutable() + if executable(l:globalExec) + return fnameescape(l:globalExec) + endif + + let l:pluginExec = s:ResolveExecutable(s:ROOT_DIR) + if executable(l:pluginExec) + return fnameescape(l:pluginExec) + endif + + return -1 +endfunction + +function! s:GetExecPath(...) abort + let l:rootDir = a:0 > 0 ? a:1 : -1 + let l:dir = l:rootDir != -1 ? l:rootDir . '/.bin/' : '' + return l:dir . 'prettier' +endfunction + +" Searches for the existence of a directory accross +" ancestral parents +function! s:TraverseAncestorDirSearch(rootDir) abort + let l:root = a:rootDir + let l:dir = 'node_modules' + + while 1 + let l:searchDir = l:root . '/' . l:dir + if isdirectory(l:searchDir) + return l:searchDir + endif + + let l:parent = fnamemodify(l:root, ':h') + if l:parent == l:root + return -1 + endif + + let l:root = l:parent + endwhile +endfunction + +function! s:ResolveExecutable(...) abort + let l:rootDir = a:0 > 0 ? a:1 : 0 + let l:exec = -1 + + if isdirectory(l:rootDir) + let l:dir = s:TraverseAncestorDirSearch(l:rootDir) + if l:dir != -1 + let l:exec = s:GetExecPath(l:dir) + endif + else + let l:exec = s:GetExecPath() + endif + + return l:exec +endfunction -- cgit v1.3-6-g1900 From 6672adfa1b05d8dc7450052df69a1ffd559eca1e Mon Sep 17 00:00:00 2001 From: mitermayer Date: Thu, 3 May 2018 13:46:30 -0700 Subject: Moving argument build into config resolver module --- autoload/prettier.vim | 75 +---------------------------------- autoload/prettier/resolver/config.vim | 72 +++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 74 deletions(-) create mode 100644 autoload/prettier/resolver/config.vim (limited to 'autoload/prettier/resolver') diff --git a/autoload/prettier.vim b/autoload/prettier.vim index d7c4338..c1aa35b 100644 --- a/autoload/prettier.vim +++ b/autoload/prettier.vim @@ -44,7 +44,7 @@ function! prettier#Prettier(...) abort let l:config = getbufvar(bufnr('%'), 'prettier_ft_default_args', {}) if l:execCmd != -1 - let l:cmd = l:execCmd . s:Get_Prettier_Exec_Args(l:config) + let l:cmd = l:execCmd . prettier#resolver#config#buildCliArgs(l:config) " close quickfix if it is opened if s:prettier_quickfix_open @@ -259,79 +259,6 @@ function! s:Apply_Prettier_Format(lines, startSelection, endSelection) abort call winrestview(l:winview) endfunction -" Returns either '--use-tabs' or an empty string. -function! s:Flag_use_tabs(config) abort - let l:value = get(a:config, 'useTabs', g:prettier#config#use_tabs) - if (l:value ==# 'auto') - let l:value = &expandtab ? 'false' : 'true' - endif - - if ( l:value ==# 'true' ) - return '--use-tabs' - else - return '' - endif -endfunction - -" Returns '--tab-width=NN' -function! s:Flag_tab_width(config) abort - let l:value = get(a:config, 'tabWidth', g:prettier#config#tab_width) - - if (l:value ==# 'auto') - let l:value = prettier#utils#shim#shiftwidth() - endif - - return '--tab-width=' . l:value -endfunction - -" Returns '--print-width=NN' or '' -function! s:Flag_print_width(config) abort - let l:value = get(a:config, 'printWidth', g:prettier#config#print_width) - - if (l:value ==# 'auto') - let l:value = &textwidth - endif - - if (l:value > 0) - return '--print-width=' . l:value - else - return '' - endif -endfunction - -" Returns '--parser=PARSER' or '' -function! s:Flag_parser(config) abort - let l:value = get(a:config, 'parser', g:prettier#config#parser) - - if (l:value !=# '') - return '--parser=' . l:value - else - return '' - endif -endfunction - -" By default we will default to our internal -" configuration settings for prettier -function! s:Get_Prettier_Exec_Args(config) abort - " Allow params to be passed as json format - " convert bellow usage of globals to a get function o the params defaulting to global - " TODO: Use a list, filter() and join() to get a nicer list of args. - let l:cmd = s:Flag_use_tabs(a:config) . ' ' . - \ s:Flag_tab_width(a:config) . ' ' . - \ s:Flag_print_width(a:config) . ' ' . - \ s:Flag_parser(a:config) . ' ' . - \ ' --config-precedence=' . - \ get(a:config, 'configPrecedence', g:prettier#config#config_precedence) . - \ ' --prose-wrap=' . - \ get(a:config, 'proseWrap', g:prettier#config#prose_wrap) . - \ ' --stdin-filepath=' . - \ simplify(expand('%:p')) . - \ ' --no-editorconfig '. - \ ' --loglevel error '. - \ ' --stdin ' - return l:cmd -endfunction - function! s:Prettier_Parse_Error(errors) abort call prettier#logging#error#log('PARSING_ERROR') if g:prettier#quickfix_enabled && prettier#bridge#parser#onError(a:errors) diff --git a/autoload/prettier/resolver/config.vim b/autoload/prettier/resolver/config.vim new file mode 100644 index 0000000..ffdd8ff --- /dev/null +++ b/autoload/prettier/resolver/config.vim @@ -0,0 +1,72 @@ +" By default we will default to our internal +" configuration settings for prettier +function! prettier#resolver#config#buildCliArgs(config) abort + " Allow params to be passed as json format + " convert bellow usage of globals to a get function o the params defaulting to global + " TODO: Use a list, filter() and join() to get a nicer list of args. + let l:cmd = s:Flag_use_tabs(a:config) . ' ' . + \ s:Flag_tab_width(a:config) . ' ' . + \ s:Flag_print_width(a:config) . ' ' . + \ s:Flag_parser(a:config) . ' ' . + \ ' --config-precedence=' . + \ get(a:config, 'configPrecedence', g:prettier#config#config_precedence) . + \ ' --prose-wrap=' . + \ get(a:config, 'proseWrap', g:prettier#config#prose_wrap) . + \ ' --stdin-filepath=' . + \ simplify(expand('%:p')) . + \ ' --no-editorconfig '. + \ ' --loglevel error '. + \ ' --stdin ' + return l:cmd +endfunction + +" Returns '--tab-width=NN' +function! s:Flag_tab_width(config) abort + let l:value = get(a:config, 'tabWidth', g:prettier#config#tab_width) + + if (l:value ==# 'auto') + let l:value = prettier#utils#shim#shiftwidth() + endif + + return '--tab-width=' . l:value +endfunction + +" Returns either '--use-tabs' or an empty string. +function! s:Flag_use_tabs(config) abort + let l:value = get(a:config, 'useTabs', g:prettier#config#use_tabs) + if (l:value ==# 'auto') + let l:value = &expandtab ? 'false' : 'true' + endif + + if ( l:value ==# 'true' ) + return '--use-tabs' + else + return '' + endif +endfunction + +" Returns '--print-width=NN' or '' +function! s:Flag_print_width(config) abort + let l:value = get(a:config, 'printWidth', g:prettier#config#print_width) + + if (l:value ==# 'auto') + let l:value = &textwidth + endif + + if (l:value > 0) + return '--print-width=' . l:value + else + return '' + endif +endfunction + +" Returns '--parser=PARSER' or '' +function! s:Flag_parser(config) abort + let l:value = get(a:config, 'parser', g:prettier#config#parser) + + if (l:value !=# '') + return '--parser=' . l:value + else + return '' + endif +endfunction -- cgit v1.3-6-g1900 From 98845cdbbe243f4a62adbd73cbe7febec1f41efa Mon Sep 17 00:00:00 2001 From: mitermayer Date: Thu, 10 May 2018 13:36:09 -0700 Subject: Adding presets - adding facebook presets as a configurable option to overwrite prettier defaults --- autoload/prettier.vim | 2 +- autoload/prettier/presets/fb.vim | 13 +++++++++++++ autoload/prettier/resolver/config.vim | 14 ++++++++++++++ autoload/prettier/resolver/preset.vim | 8 ++++++++ plugin/prettier.vim | 34 ++++++++++++++++++++++++++++++++-- 5 files changed, 68 insertions(+), 3 deletions(-) create mode 100644 autoload/prettier/presets/fb.vim create mode 100644 autoload/prettier/resolver/preset.vim (limited to 'autoload/prettier/resolver') diff --git a/autoload/prettier.vim b/autoload/prettier.vim index c5e21e5..fae1ef8 100644 --- a/autoload/prettier.vim +++ b/autoload/prettier.vim @@ -72,7 +72,7 @@ function! prettier#Prettier(...) abort let l:config = getbufvar(bufnr('%'), 'prettier_ft_default_args', {}) if l:execCmd != -1 - let l:cmd = l:execCmd . prettier#resolver#config#buildCliArgs(l:config) + let l:cmd = l:execCmd . prettier#resolver#config#buildCliArgs(prettier#resolver#preset#build(l:config)) " close quickfix if it is opened call prettier#utils#quickfix#close() diff --git a/autoload/prettier/presets/fb.vim b/autoload/prettier/presets/fb.vim new file mode 100644 index 0000000..4715b88 --- /dev/null +++ b/autoload/prettier/presets/fb.vim @@ -0,0 +1,13 @@ +" Return facebook style config overwrite presets +function! prettier#presets#fb#config() abort + return { + \ 'bracketSpacing': 'false', + \ 'jsxBracketSameLine': 'true', + \ 'printWidth': 80, + \ 'parser': 'flow', + \ 'singleQuote': 'true', + \ 'tabWidth': 2, + \ 'trailingComma': 'all', + \ 'useTabs': 'false', + \ } +endfunction diff --git a/autoload/prettier/resolver/config.vim b/autoload/prettier/resolver/config.vim index ffdd8ff..91fc247 100644 --- a/autoload/prettier/resolver/config.vim +++ b/autoload/prettier/resolver/config.vim @@ -8,6 +8,18 @@ function! prettier#resolver#config#buildCliArgs(config) abort \ s:Flag_tab_width(a:config) . ' ' . \ s:Flag_print_width(a:config) . ' ' . \ s:Flag_parser(a:config) . ' ' . + \ ' --semi=' . + \ get(a:config, 'semi', g:prettier#config#semi) . + \ ' --single-quote=' . + \ get(a:config, 'singleQuote', g:prettier#config#single_quote) . + \ ' --bracket-spacing=' . + \ get(a:config, 'bracketSpacing', g:prettier#config#bracket_spacing) . + \ ' --jsx-bracket-same-line=' . + \ get(a:config, 'jsxBracketSameLine', g:prettier#config#jsx_bracket_same_line) . + \ ' --arrow-parens=' . + \ get(a:config, 'arrowParens', g:prettier#config#arrow_parens) . + \ ' --trailing-comma=' . + \ get(a:config, 'trailingComma', g:prettier#config#trailing_comma) . \ ' --config-precedence=' . \ get(a:config, 'configPrecedence', g:prettier#config#config_precedence) . \ ' --prose-wrap=' . @@ -17,6 +29,8 @@ function! prettier#resolver#config#buildCliArgs(config) abort \ ' --no-editorconfig '. \ ' --loglevel error '. \ ' --stdin ' + " TODO + " check to see if --no-editorconfig is still needed return l:cmd endfunction diff --git a/autoload/prettier/resolver/preset.vim b/autoload/prettier/resolver/preset.vim new file mode 100644 index 0000000..a0891d2 --- /dev/null +++ b/autoload/prettier/resolver/preset.vim @@ -0,0 +1,8 @@ +" Build config using predefined preset +function! prettier#resolver#preset#build(fileTypeConfigOverwrites) abort + if ( g:prettier#preset#config ==# 'fb' ) + return extend(prettier#presets#fb#config(), a:fileTypeConfigOverwrites) + endif + + return a:fileTypeConfigOverwrites +endfunction diff --git a/plugin/prettier.vim b/plugin/prettier.vim index 5de9caf..2bb5a39 100644 --- a/plugin/prettier.vim +++ b/plugin/prettier.vim @@ -29,6 +29,13 @@ let g:prettier#exec_cmd_async = get(g:, 'prettier#exec_cmd_async', 0) " when having formatting errors will open the quickfix by default let g:prettier#quickfix_enabled = get(g:, 'prettier#quickfix_enabled', 1) +" Don't leave the quicklist focused on error. +let g:prettier#quickfix_auto_focus = get(g:, 'prettier#quickfix_auto_focus', 1) + +" default|fb +" Use prettier defaults +let g:prettier#preset#config = get(g:,'prettier#preset#config', 'default') + " => Prettier CLI config " Max line length that prettier will wrap on: a number or 'auto' (use " textwidth). @@ -57,8 +64,31 @@ let g:prettier#config#config_precedence = get(g:, 'prettier#config#config_preced " default: 'preserve' let g:prettier#config#prose_wrap = get(g:, 'prettier#config#prose_wrap', 'preserve') -" Don't leave the quicklist focused on error. -let g:prettier#quickfix_auto_focus = get(g:, 'prettier#quickfix_auto_focus', 1) +" print semicolons +" default: 'true' +let g:prettier#config#semi = get(g:,'prettier#config#semi', 'true') + +" Use single quotes instead of double quotes. +" default: 'false' +let g:prettier#config#single_quote = get(g:,'prettier#config#single_quote', 'false') + +" print spaces between brackets +" default: 'true' +let g:prettier#config#bracket_spacing = get(g:,'prettier#config#bracket_spacing', 'true') + +" put > on the last line instead of new line +" default: 'false' +let g:prettier#config#jsx_bracket_same_line = get(g:,'prettier#config#jsx_bracket_same_line', 'false') + +" avoid wrapping a single arrow function param in parens +" avoid|always +" default: 'avoid' +let g:prettier#config#arrow_parens = get(g:,'prettier#config#arrow_parens', 'avoid') + +" Print trailing commas wherever possible when multi-line. +" none|es5|all +" default: 'none' +let g:prettier#config#trailing_comma = get(g:,'prettier#config#trailing_comma', 'none') " synchronous by default command! -nargs=? -range=% Prettier call prettier#Prettier(g:prettier#exec_cmd_async, , ) -- cgit v1.3-6-g1900 From ec6ede90f3b9948ed7063402189653f8d6721326 Mon Sep 17 00:00:00 2001 From: mitermayer Date: Mon, 28 May 2018 20:53:30 -0700 Subject: Enabling partial formatting but still maintaining support for fragment formatting --- README.md | 2 +- autoload/prettier.vim | 18 +++++++++++++++++- autoload/prettier/resolver/config.vim | 14 +++++++++++++- autoload/prettier/resolver/preset.vim | 2 +- autoload/prettier/utils/buffer.vim | 21 +++++++++++++++++++++ plugin/prettier.vim | 15 +++++++++++++-- 6 files changed, 66 insertions(+), 6 deletions(-) (limited to 'autoload/prettier/resolver') diff --git a/README.md b/README.md index 442a821..d0ec620 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ By default it will auto format **javascript**, **typescript**, **less**, **scss**, **css**, **json**, **graphql** and **markdown** files if they have/support the "@format" pragma annotation in the header of the file. -![vim-prettier](/media/vim-prettier.gif?raw=true "vim-prettier") +![vim-prettier](/media/vim-prettier.gif?raw=true 'vim-prettier') ### INSTALL diff --git a/autoload/prettier.vim b/autoload/prettier.vim index fae1ef8..0e8ade3 100644 --- a/autoload/prettier.vim +++ b/autoload/prettier.vim @@ -69,14 +69,30 @@ function! prettier#Prettier(...) abort let l:async = a:0 > 0 ? a:1 : 0 let l:startSelection = a:0 > 1 ? a:2 : 1 let l:endSelection = a:0 > 2 ? a:3 : line('$') + let l:hasSelection = a:0 > 2 ? 1 : 0 + let l:partialFormat = a:0 > 3 && a:4 ? a:4 : 0 let l:config = getbufvar(bufnr('%'), 'prettier_ft_default_args', {}) + let l:partialFormatEnabled = l:hasSelection && l:partialFormat if l:execCmd != -1 - let l:cmd = l:execCmd . prettier#resolver#config#buildCliArgs(prettier#resolver#preset#build(l:config)) + " TODO + " => we should make sure we can resolve --range-start and --range-end when required + " => when the above is required we should also update l:startSelection to '1' and l:endSelection to line('$') + let l:cmd = l:execCmd . prettier#resolver#config#resolve( + \ prettier#resolver#preset#resolve(l:config), + \ l:partialFormatEnabled, + \ l:startSelection, + \ l:endSelection) " close quickfix if it is opened call prettier#utils#quickfix#close() + " we will be using portion formatting, so we need to send entire buffer to prettier + if l:partialFormatEnabled + let l:startSelection = 1 + let l:endSelection = line('$') + endif + " format buffer call prettier#job#runner#run(l:cmd, l:startSelection, l:endSelection, l:async) else diff --git a/autoload/prettier/resolver/config.vim b/autoload/prettier/resolver/config.vim index 91fc247..eae6725 100644 --- a/autoload/prettier/resolver/config.vim +++ b/autoload/prettier/resolver/config.vim @@ -1,6 +1,6 @@ " By default we will default to our internal " configuration settings for prettier -function! prettier#resolver#config#buildCliArgs(config) abort +function! prettier#resolver#config#resolve(config, hasSelection, start, end) abort " Allow params to be passed as json format " convert bellow usage of globals to a get function o the params defaulting to global " TODO: Use a list, filter() and join() to get a nicer list of args. @@ -8,6 +8,7 @@ function! prettier#resolver#config#buildCliArgs(config) abort \ s:Flag_tab_width(a:config) . ' ' . \ s:Flag_print_width(a:config) . ' ' . \ s:Flag_parser(a:config) . ' ' . + \ s:Flag_range_delimiter(a:config, a:hasSelection, a:start, a:end) . ' ' . \ ' --semi=' . \ get(a:config, 'semi', g:prettier#config#semi) . \ ' --single-quote=' . @@ -34,6 +35,17 @@ function! prettier#resolver#config#buildCliArgs(config) abort return l:cmd endfunction +" Returns either '--range-start X --range-end Y' or an empty string. +function! s:Flag_range_delimiter(config, partialFormatEnabled, start, end) abort + if (!a:partialFormatEnabled) + return '' + endif + + let l:range = prettier#utils#buffer#getCharRange(a:start, a:end) + + return '--range-start=' . l:range[0] . ' --range-end=' . l:range[1] +endfunction + " Returns '--tab-width=NN' function! s:Flag_tab_width(config) abort let l:value = get(a:config, 'tabWidth', g:prettier#config#tab_width) diff --git a/autoload/prettier/resolver/preset.vim b/autoload/prettier/resolver/preset.vim index a0891d2..03f98ee 100644 --- a/autoload/prettier/resolver/preset.vim +++ b/autoload/prettier/resolver/preset.vim @@ -1,5 +1,5 @@ " Build config using predefined preset -function! prettier#resolver#preset#build(fileTypeConfigOverwrites) abort +function! prettier#resolver#preset#resolve(fileTypeConfigOverwrites) abort if ( g:prettier#preset#config ==# 'fb' ) return extend(prettier#presets#fb#config(), a:fileTypeConfigOverwrites) endif diff --git a/autoload/prettier/utils/buffer.vim b/autoload/prettier/utils/buffer.vim index 1e11ddb..0b3c619 100644 --- a/autoload/prettier/utils/buffer.vim +++ b/autoload/prettier/utils/buffer.vim @@ -33,3 +33,24 @@ endfunction function! prettier#utils#buffer#createBufferFromUpdatedLines(lines, start, end) abort return getbufline(bufnr('%'), 1, a:start - 1) + a:lines + getbufline(bufnr('%'), a:end + 1, '$') endfunction + +" Adapted from https://github.com/farazdagi/vim-go-ide +function! s:getCharPosition(line, col) + if &encoding !=# 'utf-8' + " On utf-8 enconding we can't just use bytes so we need to make sure we can count the + " characters, we do that by adding the text into a temporary buffer and counting the chars + let l:buf = a:line == 1 ? '' : (join(getline(1, a:line - 1), "\n") . "\n") + let l:buf .= a:col == 1 ? '' : getline('.')[:a:col - 2] + return len(iconv(l:buf, &encoding, 'utf-8')) + endif + " On non utf-8 the line byte should match the character + return line2byte(a:line) + (a:col - 2) +endfun + +" Returns [start, end] byte range when on visual mode +function! prettier#utils#buffer#getCharRange(startSelection, endSelection) abort + let l:range = [] + call add(l:range, s:getCharPosition(a:startSelection, col("'<"))) + call add(l:range, s:getCharPosition(a:endSelection, col("'>"))) + return l:range +endfunction diff --git a/plugin/prettier.vim b/plugin/prettier.vim index 2bb5a39..4a3db64 100644 --- a/plugin/prettier.vim +++ b/plugin/prettier.vim @@ -32,6 +32,9 @@ let g:prettier#quickfix_enabled = get(g:, 'prettier#quickfix_enabled', 1) " Don't leave the quicklist focused on error. let g:prettier#quickfix_auto_focus = get(g:, 'prettier#quickfix_auto_focus', 1) +" Send to prettier entire buffer and use --range-start and --range-end as delimter +let g:prettier#partial_format = get(g:, 'prettier#partial_format', 0) + " default|fb " Use prettier defaults let g:prettier#preset#config = get(g:,'prettier#preset#config', 'default') @@ -91,10 +94,10 @@ let g:prettier#config#arrow_parens = get(g:,'prettier#config#arrow_parens', 'avo let g:prettier#config#trailing_comma = get(g:,'prettier#config#trailing_comma', 'none') " synchronous by default -command! -nargs=? -range=% Prettier call prettier#Prettier(g:prettier#exec_cmd_async, , ) +command! -nargs=? -range=% Prettier call prettier#Prettier(g:prettier#exec_cmd_async, , , g:prettier#partial_format) " prettier async -command! -nargs=? -range=% PrettierAsync call prettier#Prettier(1, , ) +command! -nargs=? -range=% PrettierAsync call prettier#Prettier(1, , , g:prettier#partial_format) " prints vim-prettier version command! -nargs=? -range=% PrettierVersion echom '0.2.6' @@ -108,12 +111,20 @@ command! -nargs=? -range=% PrettierCliVersion call prettier#PrettierCli('--versi " prints prettier resolved cli path command! -nargs=? -range=% PrettierCliPath call prettier#PrettierCliPath() +" sends selected text to prettier cli for formatting +command! -nargs=? -range=% PrettierFragment call prettier#Prettier(g:prettier#exec_cmd_async, , , 0) + +" sends entire buffer to prettier cli but format just selection +command! -nargs=? -range=% PrettierPartial call prettier#Prettier(g:prettier#exec_cmd_async, , , 1) + " map command if !hasmapto('(Prettier)') && maparg('p', 'n') ==# '' nmap p (Prettier) endif nnoremap (Prettier) :Prettier nnoremap (PrettierAsync) :PrettierAsync +nnoremap (PrettierFragment) :PrettierFragment +nnoremap (PrettierPartial) :PrettierPartial nnoremap (PrettierVersion) :PrettierVersion nnoremap (PrettierCli) :PrettierCli nnoremap (PrettierCliVersion) :PrettierCliVersion -- cgit v1.3-6-g1900 From 9078adb61e8678c5526e03803008636452181c98 Mon Sep 17 00:00:00 2001 From: mitermayer Date: Mon, 5 Nov 2018 21:41:24 -0800 Subject: removing already actioned todo --- autoload/prettier/resolver/config.vim | 2 -- 1 file changed, 2 deletions(-) (limited to 'autoload/prettier/resolver') diff --git a/autoload/prettier/resolver/config.vim b/autoload/prettier/resolver/config.vim index 3a1caf9..697673c 100644 --- a/autoload/prettier/resolver/config.vim +++ b/autoload/prettier/resolver/config.vim @@ -29,8 +29,6 @@ function! prettier#resolver#config#resolve(config, hasSelection, start, end) abo \ simplify(expand('%:p')) . \ ' --loglevel error '. \ ' --stdin ' - " TODO - " check to see if --no-editorconfig is still needed return l:cmd endfunction -- cgit v1.3-6-g1900 From ae216f6cdfdc219108b4a43227575bdc4d96a54f Mon Sep 17 00:00:00 2001 From: Andrei Glingeanu Date: Tue, 6 Nov 2018 11:16:49 +0200 Subject: space for --use-tabs --- autoload/prettier/resolver/config.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'autoload/prettier/resolver') diff --git a/autoload/prettier/resolver/config.vim b/autoload/prettier/resolver/config.vim index 697673c..2db11b5 100644 --- a/autoload/prettier/resolver/config.vim +++ b/autoload/prettier/resolver/config.vim @@ -62,7 +62,7 @@ function! s:Flag_use_tabs(config) abort endif if ( l:value ==# 'true' ) - return '--use-tabs' + return ' --use-tabs' else return '' endif -- cgit v1.3-6-g1900