aboutsummaryrefslogtreecommitdiff
path: root/lib/http
diff options
context:
space:
mode:
authorShulhan <ms@kilabit.info>2023-05-20 13:42:39 +0700
committerShulhan <ms@kilabit.info>2023-05-20 13:44:07 +0700
commit3eae1d3df5eeef14f9e8389895bb6b835ac2cf78 (patch)
treef35ca6c111bed2ecf85ada965accf22ce83d3e8c /lib/http
parentf43b8ead50575c6a279bef403af0204df98323c9 (diff)
downloadpakakeh.go-3eae1d3df5eeef14f9e8389895bb6b835ac2cf78.tar.xz
all: remove any usage of debug.Value in all packages
Using global debug value for all packages turns out is not a good idea.
Diffstat (limited to 'lib/http')
-rw-r--r--lib/http/client.go20
-rw-r--r--lib/http/endpoint.go4
-rw-r--r--lib/http/server.go17
3 files changed, 0 insertions, 41 deletions
diff --git a/lib/http/client.go b/lib/http/client.go
index de14169e..fe651672 100644
--- a/lib/http/client.go
+++ b/lib/http/client.go
@@ -19,14 +19,12 @@ import (
"mime/multipart"
"net"
"net/http"
- "net/http/httputil"
"net/url"
"path"
"strings"
"time"
"github.com/shuLhan/share"
- "github.com/shuLhan/share/lib/debug"
)
var (
@@ -99,29 +97,11 @@ func (client *Client) Do(httpRequest *http.Request) (
) {
logp := "Do"
- if debug.Value >= 3 {
- dump, err := httputil.DumpRequestOut(httpRequest, true)
- if err != nil {
- log.Printf("%s: %s\n", logp, err)
- } else {
- fmt.Printf("%s\n", dump)
- }
- }
-
httpRes, err = client.Client.Do(httpRequest)
if err != nil {
return nil, nil, fmt.Errorf("%s: %w", logp, err)
}
- if debug.Value >= 3 {
- dump, err := httputil.DumpResponse(httpRes, true)
- if err != nil {
- log.Printf("%s: %s", logp, err)
- } else {
- fmt.Printf("%s\n", dump)
- }
- }
-
rawBody, err := io.ReadAll(httpRes.Body)
if err != nil {
return nil, nil, fmt.Errorf("%s: %w", logp, err)
diff --git a/lib/http/endpoint.go b/lib/http/endpoint.go
index 9869b0ca..5692ed2f 100644
--- a/lib/http/endpoint.go
+++ b/lib/http/endpoint.go
@@ -10,7 +10,6 @@ import (
"net/http"
"net/url"
- "github.com/shuLhan/share/lib/debug"
"github.com/shuLhan/share/lib/mlog"
)
@@ -108,9 +107,6 @@ func (ep *Endpoint) call(
return
}
- if debug.Value >= 3 {
- mlog.Outf("%s: %s %s: request body: %s", logp, req.Method, req.URL.Path, epr.RequestBody)
- }
if len(vals) > 0 && req.Form == nil {
req.Form = make(url.Values, len(vals))
}
diff --git a/lib/http/server.go b/lib/http/server.go
index 7bcff8ef..181607e1 100644
--- a/lib/http/server.go
+++ b/lib/http/server.go
@@ -20,7 +20,6 @@ import (
"time"
"github.com/shuLhan/share/lib/ascii"
- "github.com/shuLhan/share/lib/debug"
"github.com/shuLhan/share/lib/memfs"
"github.com/shuLhan/share/lib/mlog"
)
@@ -241,14 +240,6 @@ func (srv *Server) registerPut(ep *Endpoint) (err error) {
// ServeHTTP handle mapping of client request to registered endpoints.
func (srv *Server) ServeHTTP(res http.ResponseWriter, req *http.Request) {
- var (
- logp = "ServeHTTP"
- )
-
- if debug.Value >= 3 {
- mlog.Outf("%s: %s %+v", logp, req.Method, req.URL)
- }
-
switch req.Method {
case http.MethodDelete:
srv.handleDelete(res, req)
@@ -307,8 +298,6 @@ func (srv *Server) Stop(wait time.Duration) (err error) {
func (srv *Server) getFSNode(reqPath string) (node *memfs.Node) {
var (
- logp = "getFSNode"
-
nodeIndexHtml *memfs.Node
pathHtml string
err error
@@ -323,9 +312,6 @@ func (srv *Server) getFSNode(reqPath string) (node *memfs.Node) {
node, err = srv.Options.Memfs.Get(reqPath)
if err != nil {
if !errors.Is(err, os.ErrNotExist) {
- if debug.Value >= 3 {
- mlog.Outf("%s: %q: %s", logp, reqPath, err)
- }
return nil
}
@@ -334,9 +320,6 @@ func (srv *Server) getFSNode(reqPath string) (node *memfs.Node) {
pathHtml = reqPath + `.html`
node, err = srv.Options.Memfs.Get(pathHtml)
if err != nil {
- if debug.Value >= 3 {
- mlog.Outf("%s: %q: %s", logp, reqPath, err)
- }
return nil
}
return node