diff options
| author | Shulhan <ms@kilabit.info> | 2018-11-30 10:23:29 +0700 |
|---|---|---|
| committer | Shulhan <ms@kilabit.info> | 2018-11-30 10:23:29 +0700 |
| commit | 645c7bb752465782a4e46b703c5250d345b495bd (patch) | |
| tree | e0099dbc8dce592b2e491c19c8ae41bfc68c6b68 /lib/git | |
| parent | b077d6796655e1be9864e0c64068bdcd5d1d2649 (diff) | |
| download | pakakeh.go-645c7bb752465782a4e46b703c5250d345b495bd.tar.xz | |
all: fix linter warnings on naked return
Diffstat (limited to 'lib/git')
| -rw-r--r-- | lib/git/git.go | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/lib/git/git.go b/lib/git/git.go index 5b15ed59..e8b1bbdb 100644 --- a/lib/git/git.go +++ b/lib/git/git.go @@ -285,13 +285,12 @@ func LatestTag(repoDir string) (tag string, err error) { bout, err := cmd.Output() if err != nil { - err = fmt.Errorf("LatestTag: %s", err) - return + return "", fmt.Errorf("LatestTag: %s", err) } out := string(bytes.TrimSpace(bout)) if len(out) == 0 { - return + return "", nil } cmd = exec.Command("git") @@ -305,13 +304,12 @@ func LatestTag(repoDir string) (tag string, err error) { bout, err = cmd.Output() if err != nil { - err = fmt.Errorf("LatestTag: %s", err) - return + return "", fmt.Errorf("LatestTag: %s", err) } tag = string(bytes.TrimSpace(bout)) - return + return tag, nil } // @@ -339,7 +337,7 @@ func LatestVersion(repoDir string) (version string, err error) { func ListTags(repoDir string) (tags []string, err error) { err = FetchTags(repoDir) if err != nil { - return + return nil, err } cmd := exec.Command("git") @@ -354,7 +352,7 @@ func ListTags(repoDir string) (tags []string, err error) { bout, err := cmd.Output() if err != nil { err = fmt.Errorf("ListTag: %s", err) - return + return nil, err } sep := []byte{'\n'} @@ -367,7 +365,7 @@ func ListTags(repoDir string) (tags []string, err error) { tags = append(tags, string(btags[x])) } - return + return tags, nil } // |
