diff options
| author | Shulhan <ms@kilabit.info> | 2023-12-13 01:20:26 +0700 |
|---|---|---|
| committer | Shulhan <ms@kilabit.info> | 2023-12-13 01:20:26 +0700 |
| commit | 77c0cbe885985e6ccaf530226a34b24fef65b27e (patch) | |
| tree | bf43f4b7cd879561fc837315a53cf815da473244 /api | |
| parent | bb198ad2d7a3f26c8ee0f32abfc8384c79df404f (diff) | |
| download | pakakeh.go-77c0cbe885985e6ccaf530226a34b24fef65b27e.tar.xz | |
all: fix linter warnings reported by revive
There are some reports that I disagree with revive, in example, code
should not declare the type after variables.
In my opinion, on some cases, declaring the type make the code more
readable and explicit.
Since I did not want to add new configuration file, we changes it and
follow revive for now.
Diffstat (limited to 'api')
| -rw-r--r-- | api/slack/message.go | 2 | ||||
| -rw-r--r-- | api/slack/slack.go | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/api/slack/message.go b/api/slack/message.go index 6325f0d4..2a62c200 100644 --- a/api/slack/message.go +++ b/api/slack/message.go @@ -9,6 +9,6 @@ type Message struct { Channel string `json:"channel,omitempty"` Username string `json:"username,omitempty"` IconEmoji string `json:"icon_emoji,omitempty"` - IconUrl string `json:"icon_url,omitempty"` + IconUrl string `json:"icon_url,omitempty"` //revive:disable-line Text string `json:"text"` } diff --git a/api/slack/slack.go b/api/slack/slack.go index dca2e3b1..6ed1906e 100644 --- a/api/slack/slack.go +++ b/api/slack/slack.go @@ -15,7 +15,7 @@ import ( ) // PostWebhook send a message using "Incoming Webhook". -func PostWebhook(webhookUrl string, msg *Message) (err error) { +func PostWebhook(webhookURL string, msg *Message) (err error) { var ( logp = `PostWebhook` @@ -29,7 +29,7 @@ func PostWebhook(webhookUrl string, msg *Message) (err error) { var res *http.Response - res, err = http.DefaultClient.Post(webhookUrl, `application/json`, bytes.NewReader(payload)) + res, err = http.DefaultClient.Post(webhookURL, `application/json`, bytes.NewReader(payload)) if err != nil { return fmt.Errorf(`%s: %w`, logp, err) } |
