aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShulhan <m.shulhan@gmail.com>2019-08-29 00:53:31 +0700
committerShulhan <m.shulhan@gmail.com>2019-08-29 00:53:31 +0700
commita8efbba8519f447da2fb24e0a9168d2b11f1e151 (patch)
tree9b511b8365cb56bb4202a7e032b9971de397de1f
parent9e7e3ee2def1b6141143b5e4dc27a976f5ec779d (diff)
downloadpakakeh.go-a8efbba8519f447da2fb24e0a9168d2b11f1e151.tar.xz
memfs: replace if-statement with two conditions with nested if-statements
This changes mostly for readibility. It becomes harder to read and trace the state of double conditions on New() method.
-rw-r--r--lib/memfs/memfs.go22
1 files changed, 13 insertions, 9 deletions
diff --git a/lib/memfs/memfs.go b/lib/memfs/memfs.go
index a9669d0a..25c8362e 100644
--- a/lib/memfs/memfs.go
+++ b/lib/memfs/memfs.go
@@ -66,16 +66,18 @@ type MemFS struct {
// excludes does not have any effect, since the content of path and nodes will
// be overwritten by GeneratedPathNode.
//
-func New(includes, excludes []string, withContent bool) (*MemFS, error) {
- if !Development && GeneratedPathNode != nil {
- mfs := &MemFS{
- pn: GeneratedPathNode,
- root: GeneratedPathNode.Get("/"),
+func New(includes, excludes []string, withContent bool) (mfs *MemFS, err error) {
+ if GeneratedPathNode != nil {
+ if !Development {
+ mfs = &MemFS{
+ pn: GeneratedPathNode,
+ root: GeneratedPathNode.Get("/"),
+ }
+ return mfs, nil
}
- return mfs, nil
}
- mfs := &MemFS{
+ mfs = &MemFS{
pn: &PathNode{
v: make(map[string]*Node),
f: nil,
@@ -227,8 +229,10 @@ func (mfs *MemFS) Mount(dir string) error {
if len(dir) == 0 {
return nil
}
- if !Development && GeneratedPathNode != nil {
- return nil
+ if GeneratedPathNode != nil {
+ if !Development {
+ return nil
+ }
}
if mfs.pn == nil {