all: fix various linter warnings

While at it, temporary disable gosec due to excessive report for G115,
which may be true, but may also break the current working program.
We should alter and fix once we can test and make sure that it does not
breaks.

10 files changed, 32 insertions, 31 deletions

diff --git a/Makefile b/Makefile
index b42c97d9..80a06821 100644
--- a/Makefile
+++ b/Makefile
@@ -40,9 +40,11 @@ lint:
 	-shadow ./...
 	-golangci-lint run \
 		--presets bugs,metalinter,performance,unused \
+		--disable bodyclose \
 		--disable exhaustive \
+		--disable fatcontext \
+		--disable gosec \
 		--disable musttag \
-		--disable bodyclose \
 		./...
 
 $(CIIGO):
diff --git a/cmd/emaildecode/main.go b/cmd/emaildecode/main.go
index 970af753..4bf69511 100644
--- a/cmd/emaildecode/main.go
+++ b/cmd/emaildecode/main.go
@@ -54,8 +54,7 @@ func main() {
 		log.Fatalf(`missing file input`)
 	}
 
-	switch fileInput {
-	case cmdHelp:
+	if fileInput == cmdHelp {
 		fmt.Println(usage)
 		os.Exit(0)
 	}
diff --git a/lib/email/mime.go b/lib/email/mime.go
index 17d88bf4..8daef071 100644
--- a/lib/email/mime.go
+++ b/lib/email/mime.go
@@ -150,7 +150,7 @@ func (mime *MIME) decode(encoding string) (err error) {
 	var logp = `decode`
 
 	if mime.Header != nil {
-		var partEncoding []*Field = mime.Header.Filter(FieldTypeContentTransferEncoding)
+		var partEncoding = mime.Header.Filter(FieldTypeContentTransferEncoding)
 		var npart = len(partEncoding)
 		if npart > 0 {
 			encoding = strings.TrimSpace(partEncoding[npart-1].Value)
diff --git a/lib/ini/ini_test.go b/lib/ini/ini_test.go
index 2056bece..b50869cc 100644
--- a/lib/ini/ini_test.go
+++ b/lib/ini/ini_test.go
@@ -183,7 +183,7 @@ func TestSave(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.desc)
+		t.Log(c.desc)
 
 		cfg, err := Open(c.inFile)
 		if err != nil {
diff --git a/lib/memfs/internal/test/embed/embed_test.go b/lib/memfs/internal/test/embed/embed_test.go
index 06b16d3a..1dcfc954 100644
--- a/lib/memfs/internal/test/embed/embed_test.go
+++ b/lib/memfs/internal/test/embed/embed_test.go
@@ -16,7 +16,7 @@ func generate_testdata() *memfs.Node {
 		GenFuncName: "generate_testdata",
 	}
 	node.SetMode(0o20000000755)
-	node.SetModTimeUnix(1699901114, 455911441)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("/")
 	node.SetSize(0)
 	node.AddChild(_memFS_getNode(memFS, "/direct", generate_testdata_direct))
@@ -37,7 +37,7 @@ func generate_testdata_direct() *memfs.Node {
 		GenFuncName: "generate_testdata_direct",
 	}
 	node.SetMode(0o20000000755)
-	node.SetModTimeUnix(1569586540, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("direct")
 	node.SetSize(0)
 	node.AddChild(_memFS_getNode(memFS, "/direct/add", generate_testdata_direct_add))
@@ -52,7 +52,7 @@ func generate_testdata_direct_add() *memfs.Node {
 		GenFuncName: "generate_testdata_direct_add",
 	}
 	node.SetMode(0o20000000755)
-	node.SetModTimeUnix(1569586540, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("add")
 	node.SetSize(0)
 	node.AddChild(_memFS_getNode(memFS, "/direct/add/file", generate_testdata_direct_add_file))
@@ -69,7 +69,7 @@ func generate_testdata_direct_add_file() *memfs.Node {
 		Content:     []byte("\x54\x65\x73\x74\x20\x64\x69\x72\x65\x63\x74\x20\x61\x64\x64\x20\x66\x69\x6C\x65\x2E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1569586540, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("file")
 	node.SetSize(22)
 	return node
@@ -84,7 +84,7 @@ func generate_testdata_direct_add_file2() *memfs.Node {
 		Content:     []byte("\x54\x65\x73\x74\x20\x64\x69\x72\x65\x63\x74\x20\x61\x64\x64\x20\x66\x69\x6C\x65\x20\x32\x2E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1569586540, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("file2")
 	node.SetSize(24)
 	return node
@@ -98,7 +98,7 @@ func generate_testdata_exclude() *memfs.Node {
 		GenFuncName: "generate_testdata_exclude",
 	}
 	node.SetMode(0o20000000755)
-	node.SetModTimeUnix(1633792794, 467899662)
+	node.SetModTimeUnix(1710216708, 236975330)
 	node.SetName("exclude")
 	node.SetSize(0)
 	node.AddChild(_memFS_getNode(memFS, "/exclude/dir", generate_testdata_exclude_dir))
@@ -116,7 +116,7 @@ func generate_testdata_exclude_dir() *memfs.Node {
 		GenFuncName: "generate_testdata_exclude_dir",
 	}
 	node.SetMode(0o20000000700)
-	node.SetModTimeUnix(1629620045, 798024232)
+	node.SetModTimeUnix(1710216708, 236975330)
 	node.SetName("dir")
 	node.SetSize(0)
 	return node
@@ -131,7 +131,7 @@ func generate_testdata_exclude_index_link_css() *memfs.Node {
 		Content:     []byte("\x62\x6F\x64\x79\x20\x7B\x0A\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("index-link.css")
 	node.SetSize(9)
 	return node
@@ -146,7 +146,7 @@ func generate_testdata_exclude_index_link_html() *memfs.Node {
 		Content:     []byte("\x3C\x68\x74\x6D\x6C\x3E\x3C\x2F\x68\x74\x6D\x6C\x3E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1588592347, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index-link.html")
 	node.SetSize(14)
 	return node
@@ -161,7 +161,7 @@ func generate_testdata_exclude_index_link_js() *memfs.Node {
 		Content:     []byte("\x66\x75\x6E\x63\x74\x69\x6F\x6E\x20\x58\x28\x29\x20\x7B\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index-link.js")
 	node.SetSize(16)
 	return node
@@ -175,7 +175,7 @@ func generate_testdata_include() *memfs.Node {
 		GenFuncName: "generate_testdata_include",
 	}
 	node.SetMode(0o20000000755)
-	node.SetModTimeUnix(1629623653, 749800911)
+	node.SetModTimeUnix(1710216708, 236975330)
 	node.SetName("include")
 	node.SetSize(0)
 	node.AddChild(_memFS_getNode(memFS, "/include/dir", generate_testdata_include_dir))
@@ -193,7 +193,7 @@ func generate_testdata_include_dir() *memfs.Node {
 		GenFuncName: "generate_testdata_include_dir",
 	}
 	node.SetMode(0o20000000700)
-	node.SetModTimeUnix(1564836597, 0)
+	node.SetModTimeUnix(1710216708, 236975330)
 	node.SetName("dir")
 	node.SetSize(0)
 	return node
@@ -208,7 +208,7 @@ func generate_testdata_include_index_css() *memfs.Node {
 		Content:     []byte("\x62\x6F\x64\x79\x20\x7B\x0A\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("index.css")
 	node.SetSize(9)
 	return node
@@ -223,7 +223,7 @@ func generate_testdata_include_index_html() *memfs.Node {
 		Content:     []byte("\x3C\x68\x74\x6D\x6C\x3E\x3C\x2F\x68\x74\x6D\x6C\x3E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1588592347, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index.html")
 	node.SetSize(14)
 	return node
@@ -238,7 +238,7 @@ func generate_testdata_include_index_js() *memfs.Node {
 		Content:     []byte("\x66\x75\x6E\x63\x74\x69\x6F\x6E\x20\x58\x28\x29\x20\x7B\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index.js")
 	node.SetSize(16)
 	return node
@@ -253,7 +253,7 @@ func generate_testdata_index_css() *memfs.Node {
 		Content:     []byte("\x62\x6F\x64\x79\x20\x7B\x0A\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 626038828)
 	node.SetName("index.css")
 	node.SetSize(9)
 	return node
@@ -268,7 +268,7 @@ func generate_testdata_index_html() *memfs.Node {
 		Content:     []byte("\x3C\x68\x74\x6D\x6C\x3E\x3C\x2F\x68\x74\x6D\x6C\x3E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1588592347, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index.html")
 	node.SetSize(14)
 	return node
@@ -283,7 +283,7 @@ func generate_testdata_index_js() *memfs.Node {
 		Content:     []byte("\x66\x75\x6E\x63\x74\x69\x6F\x6E\x20\x58\x28\x29\x20\x7B\x7D\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("index.js")
 	node.SetSize(16)
 	return node
@@ -298,7 +298,7 @@ func generate_testdata_plain() *memfs.Node {
 		Content:     []byte("\x54\x68\x69\x73\x20\x69\x73\x20\x61\x20\x70\x6C\x61\x69\x6E\x20\x74\x65\x78\x74\x2E\x0A"),
 	}
 	node.SetMode(0o644)
-	node.SetModTimeUnix(1562038157, 0)
+	node.SetModTimeUnix(1709751019, 629372161)
 	node.SetName("plain")
 	node.SetSize(22)
 	return node
diff --git a/lib/memfs/internal/test/embed/memfs_embed_test.go b/lib/memfs/internal/test/embed/memfs_embed_test.go
index 15a5f75b..738236ee 100644
--- a/lib/memfs/internal/test/embed/memfs_embed_test.go
+++ b/lib/memfs/internal/test/embed/memfs_embed_test.go
@@ -117,7 +117,7 @@ func TestNode_Readdir(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.path)
+		t.Log(c.path)
 
 		file, err := memFS.Open(c.path)
 		if err != nil {
diff --git a/lib/memfs/internal/test/embed_disable_modtime/memfs_embed_test.go b/lib/memfs/internal/test/embed_disable_modtime/memfs_embed_test.go
index 15a5f75b..738236ee 100644
--- a/lib/memfs/internal/test/embed_disable_modtime/memfs_embed_test.go
+++ b/lib/memfs/internal/test/embed_disable_modtime/memfs_embed_test.go
@@ -117,7 +117,7 @@ func TestNode_Readdir(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.path)
+		t.Log(c.path)
 
 		file, err := memFS.Open(c.path)
 		if err != nil {
diff --git a/lib/memfs/memfs_test.go b/lib/memfs/memfs_test.go
index 8275ea3b..9b82121b 100644
--- a/lib/memfs/memfs_test.go
+++ b/lib/memfs/memfs_test.go
@@ -39,7 +39,7 @@ func TestMain(m *testing.M) {
 			log.Fatal("!ok:", err)
 		}
 		if !errors.Is(perr.Err, os.ErrExist) {
-			log.Fatalf("perr: %+v %+v\n", perr.Err, os.ErrExist)
+			log.Fatalf("perr: %+v %+v", perr.Err, os.ErrExist)
 		}
 	}
 
@@ -543,7 +543,7 @@ func TestMemFS_Get_refresh_withDot(t *testing.T) {
 	t.Cleanup(func() {
 		err = os.Chdir(workDir)
 		if err != nil {
-			t.Logf(err.Error())
+			t.Log(err.Error())
 		}
 	})
 
diff --git a/lib/os/exec/exec_test.go b/lib/os/exec/exec_test.go
index 957c11f3..24cd001b 100644
--- a/lib/os/exec/exec_test.go
+++ b/lib/os/exec/exec_test.go
@@ -72,7 +72,7 @@ func TestParseCommandArg(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.in)
+		t.Log(c.in)
 		gotCmd, gotArgs := ParseCommandArgs(c.in)
 		test.Assert(t, "cmd", c.expCmd, gotCmd)
 		test.Assert(t, "args", c.expArgs, gotArgs)
diff --git a/lib/xmlrpc/response_test.go b/lib/xmlrpc/response_test.go
index ce1ebda8..d02814b2 100644
--- a/lib/xmlrpc/response_test.go
+++ b/lib/xmlrpc/response_test.go
@@ -49,7 +49,7 @@ func TestResponse_MarshalText(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.desc)
+		t.Log(c.desc)
 
 		got, err := c.resp.MarshalText()
 		if err != nil {
@@ -142,7 +142,7 @@ func TestResponse_UnmarshalText(t *testing.T) {
 	}}
 
 	for _, c := range cases {
-		t.Logf(c.desc)
+		t.Log(c.desc)
 
 		var got Response