diff options
| author | Shulhan <ms@kilabit.info> | 2023-05-30 22:34:01 +0700 |
|---|---|---|
| committer | Shulhan <ms@kilabit.info> | 2023-05-30 23:34:53 +0700 |
| commit | d3104abe1be09a89379e4ab5ec80019f2dd91f8b (patch) | |
| tree | 7a154aec6499251ec228f42f5dc89971ee25d673 | |
| parent | 4152d59e9e092d72c45e5c7298c3ad1b95d78f3b (diff) | |
| download | pakakeh.go-d3104abe1be09a89379e4ab5ec80019f2dd91f8b.tar.xz | |
lib/smtp: changes the field name for listener for clarity
This changes rename field,
* listener to listenMta since this is the socket that responsible
receiving message from other Mail Trasnfer Agent (MTA).
* tlsListener to listenSubmission since this is the socket that
responsible receiving message from Mail User Agent (MUA) for submiting
new message.
| -rw-r--r-- | lib/smtp/server.go | 35 |
1 files changed, 18 insertions, 17 deletions
diff --git a/lib/smtp/server.go b/lib/smtp/server.go index d284ce3d..6b9e978f 100644 --- a/lib/smtp/server.go +++ b/lib/smtp/server.go @@ -32,12 +32,13 @@ type Server struct { // Handler Handler - // listener is a socket that listen for new connection from client. - listener net.Listener + // listenMta is a socket that listen for new connection from other mail + // transfer agent (MTA) on port 25. + listenMta net.Listener - // tlsListener is a socket that listen for new connection from client - // on secure layer on port 465. - tlsListener net.Listener + // listenerSubmission is a socket that listen for new connection from + // client on secure layer on port 465. + listenSubmission net.Listener // mailTxQueue hold mail objects before being relayed or stored. mailTxQueue chan *MailTx @@ -108,7 +109,7 @@ func (srv *Server) Start() (err error) { go srv.serveIncoming() srv.wg.Add(1) - go srv.serveTLS() + go srv.serveSubmission() srv.wg.Wait() srv.running = false @@ -118,14 +119,14 @@ func (srv *Server) Start() (err error) { // Stop the server. func (srv *Server) Stop() { - err := srv.tlsListener.Close() + err := srv.listenSubmission.Close() if err != nil { - log.Printf("smtp: tlsListener.Close: %s", err) + log.Printf("smtp: listenSubmission.Close: %s", err) } - err = srv.listener.Close() + err = srv.listenMta.Close() if err != nil { - log.Printf("smtp: listener.Close: %s", err) + log.Printf("smtp: listenMta.Close: %s", err) } close(srv.mailTxQueue) @@ -137,9 +138,9 @@ func (srv *Server) Stop() { // 25. func (srv *Server) serveIncoming() { for { - conn, err := srv.listener.Accept() + conn, err := srv.listenMta.Accept() if err != nil { - log.Printf("smtp: listener.Accept: %s", err) + log.Printf("smtp: listenMta.Accept: %s", err) srv.wg.Done() return } @@ -150,11 +151,11 @@ func (srv *Server) serveIncoming() { } } -func (srv *Server) serveTLS() { +func (srv *Server) serveSubmission() { for { - conn, err := srv.tlsListener.Accept() + conn, err := srv.listenSubmission.Accept() if err != nil { - log.Printf("smtp: tlsListener.Accept: %s", err) + log.Printf("smtp: listenSubmission.Accept: %s", err) srv.wg.Done() return } @@ -555,7 +556,7 @@ func (srv *Server) initListener() (err error) { return err } - srv.listener, err = net.ListenTCP("tcp", addr) + srv.listenMta, err = net.ListenTCP("tcp", addr) if err != nil { return err } @@ -575,7 +576,7 @@ func (srv *Server) initListener() (err error) { srv.tlsAddress = ":465" } - srv.tlsListener, err = tls.Listen("tcp", srv.tlsAddress, tlsCfg) + srv.listenSubmission, err = tls.Listen("tcp", srv.tlsAddress, tlsCfg) return err } |
