From ec2ea40b315e8b1a3d1dc8f7987584c4e2a00ef4 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Mon, 8 Aug 2022 01:10:18 +0700 Subject: cmd/compile: restrict //go:notinheap to runtime/internal/sys So it won't be visible outside of runtime package. There are changes to make tests happy: - For test/directive*.go files, using "go:noinline" for testing misplaced directives instead. - Restrict test/fixedbugs/bug515.go for gccgo only. - For test/notinheap{2,3}.go, using runtime/cgo.Incomplete for marking the type as not-in-heap. Though it's somewhat clumsy, it's the easiest way to keep the test errors for not-in-heap types until we can cleanup further. - test/typeparam/mdempsky/11.go is about defined type in user code marked as go:notinheap, which can't happen after this CL, though. Fixes #46731 Change-Id: I869f5b2230c8a2a363feeec042e7723bbc416e8e Reviewed-on: https://go-review.googlesource.com/c/go/+/421882 Run-TryBot: Cuong Manh Le Reviewed-by: Joedian Reid Reviewed-by: David Chase TryBot-Result: Gopher Robot Reviewed-by: Keith Randall --- test/typeparam/mdempsky/11.go | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 test/typeparam/mdempsky/11.go (limited to 'test/typeparam') diff --git a/test/typeparam/mdempsky/11.go b/test/typeparam/mdempsky/11.go deleted file mode 100644 index e86c038a10..0000000000 --- a/test/typeparam/mdempsky/11.go +++ /dev/null @@ -1,16 +0,0 @@ -// errorcheck - -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -// Reported by Cuong Manh Le. - -package p - -type a struct{} - -//go:notinheap -type b a - -var _ = (*b)(new(a)) // ERROR "cannot convert" -- cgit v1.3