From 263e13d1f7d2d13782c5a63799c9979b9bbfd853 Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Mon, 12 Apr 2021 14:00:49 -0400 Subject: test: make codegen tests work with both ABIs Some codegen tests were written with the assumption that arguments and results are in memory, and with a specific stack layout. With the register ABI, the assumption is no longer true. Adjust the tests to work with both cases. - For tests expecting in memory arguments/results, change to use global variables or memory-assigned argument/results. - Allow more registers. E.g. some tests expecting register names contain only letters (e.g. AX), but it can also contain numbers (e.g. R10). - Some instruction selection changes when operate on register vs. memory, e.g. ADDQ vs. LEAQ, MOVB vs. MOVL. Accept both. TODO: mathbits.go and memops.go still need fix. Change-Id: Ic5932b4b5dd3f5d30ed078d296476b641420c4c5 Reviewed-on: https://go-review.googlesource.com/c/go/+/309335 Trust: Cherry Zhang Run-TryBot: Cherry Zhang TryBot-Result: Go Bot Reviewed-by: David Chase --- test/codegen/stack.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/codegen/stack.go') diff --git a/test/codegen/stack.go b/test/codegen/stack.go index 7d70024cdd..f28b4a3320 100644 --- a/test/codegen/stack.go +++ b/test/codegen/stack.go @@ -92,11 +92,11 @@ func ArrayInit(i, j int) [4]int { // Check that assembly output has matching offset and base register // (issue #21064). -func check_asmout(a, b int) int { +func check_asmout(b [2]int) int { runtime.GC() // use some frame // amd64:`.*b\+24\(SP\)` // arm:`.*b\+4\(FP\)` - return b + return b[1] } // Check that simple functions get promoted to nosplit, even when -- cgit v1.3