From f096b5b340f6e831cf80cd39cbf88d4656d232fa Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Fri, 4 Aug 2017 10:36:40 -0700 Subject: runtime: mark activeModules nosplit/nowritebarrier The activeModules function is called by the cgo pointer checking code, which is called by the write barrier (when GODEBUG=cgocheck=2), and as such must be nosplit/nowritebarrier. Fixes #21306 Change-Id: I57f2124f14de7f3872b2de9532abab15df95d45a Reviewed-on: https://go-review.googlesource.com/53352 Reviewed-by: Austin Clements --- src/runtime/symtab.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src') diff --git a/src/runtime/symtab.go b/src/runtime/symtab.go index 8e410c4560..e1b41ca4ff 100644 --- a/src/runtime/symtab.go +++ b/src/runtime/symtab.go @@ -409,6 +409,11 @@ var modulesSlice unsafe.Pointer // see activeModules // // A module is active once its gcdatamask and gcbssmask have been // assembled and it is usable by the GC. +// +// This is nosplit/nowritebarrier because it is called by the +// cgo pointer checking code. +//go:nosplit +//go:nowritebarrier func activeModules() []*moduledata { p := (*[]*moduledata)(atomic.Loadp(unsafe.Pointer(&modulesSlice))) if p == nil { -- cgit v1.3