From b73875ff6cae1b9c790e9c8d4e99ecb7185f8cd9 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Thu, 11 Jul 2024 00:14:33 +0700 Subject: test: re-enabled fixedbugs/notinheap.go test By using cgo.Incomplete to represent not-in-heap type. While at it, also removing the type conversions tests, since they could not be present without //go:notinheap pragma. Fixes #54846 Change-Id: I5ee2a4b6498d4100c9770ed7bd62f52623e42526 Reviewed-on: https://go-review.googlesource.com/c/go/+/597536 LUCI-TryBot-Result: Go LUCI Reviewed-by: Cherry Mui Reviewed-by: Keith Randall Auto-Submit: Cuong Manh Le --- src/cmd/internal/testdir/testdir_test.go | 1 - 1 file changed, 1 deletion(-) (limited to 'src') diff --git a/src/cmd/internal/testdir/testdir_test.go b/src/cmd/internal/testdir/testdir_test.go index 8d68591982..e64451b743 100644 --- a/src/cmd/internal/testdir/testdir_test.go +++ b/src/cmd/internal/testdir/testdir_test.go @@ -1859,7 +1859,6 @@ var types2Failures = setOf( "fixedbugs/issue20233.go", // types2 reports two instead of one error (preference: 1.17 compiler) "fixedbugs/issue20245.go", // types2 reports two instead of one error (preference: 1.17 compiler) "fixedbugs/issue31053.go", // types2 reports "unknown field" instead of "cannot refer to unexported field" - "fixedbugs/notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap ) var types2Failures32Bit = setOf( -- cgit v1.3