From a2431776ebc57ebc385d3fd9d3cc6eb89acb9d9c Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Fri, 25 Jul 2025 13:02:01 +0200 Subject: net, os, file/filepath, syscall: use slices.Equal in tests Use slices.Equal to compare slices instead of strings.Join and then comparing strings. Change-Id: Ib916002b7357bd7f4e66b853dd7af8d98eba5549 Reviewed-on: https://go-review.googlesource.com/c/go/+/690475 LUCI-TryBot-Result: Go LUCI Auto-Submit: Tobias Klauser Reviewed-by: Dmitri Shuralyov Reviewed-by: Cherry Mui --- src/syscall/dirent_test.go | 2 +- src/syscall/getdirentries_test.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'src/syscall') diff --git a/src/syscall/dirent_test.go b/src/syscall/dirent_test.go index cfa5478feb..173ccc3ed2 100644 --- a/src/syscall/dirent_test.go +++ b/src/syscall/dirent_test.go @@ -140,7 +140,7 @@ func TestDirentRepeat(t *testing.T) { // Check results slices.Sort(files) slices.Sort(files2) - if strings.Join(files, "|") != strings.Join(files2, "|") { + if !slices.Equal(files, files2) { t.Errorf("bad file list: want\n%q\ngot\n%q", files, files2) } } diff --git a/src/syscall/getdirentries_test.go b/src/syscall/getdirentries_test.go index 5d401d8dd6..b5361ddaef 100644 --- a/src/syscall/getdirentries_test.go +++ b/src/syscall/getdirentries_test.go @@ -11,7 +11,6 @@ import ( "os" "path/filepath" "slices" - "strings" "syscall" "testing" "unsafe" @@ -78,7 +77,7 @@ func testGetdirentries(t *testing.T, count int) { names = append(names, ".", "..") // Getdirentries returns these also slices.Sort(names) slices.Sort(names2) - if strings.Join(names, ":") != strings.Join(names2, ":") { + if !slices.Equal(names, names2) { t.Errorf("names don't match\n names: %q\nnames2: %q", names, names2) } } -- cgit v1.3-5-g45d5