From 95611c0eb4436102ab0dad3a705acff5f5eb7aca Mon Sep 17 00:00:00 2001 From: Prabhav Dogra Date: Sun, 20 Apr 2025 07:52:58 +0000 Subject: sync: use atomic.Bool for Once.done Updated the use of atomic.Uint32 to atomic.Bool for sync package. Change-Id: Ib8da66fea86ef06e1427ac5118016b96fbcda6b1 GitHub-Last-Rev: d36e0f431fcde988f90badf86bbf04a18a411947 GitHub-Pull-Request: golang/go#73447 Reviewed-on: https://go-review.googlesource.com/c/go/+/666895 Reviewed-by: Junyang Shao Reviewed-by: Keith Randall LUCI-TryBot-Result: Go LUCI Auto-Submit: Keith Randall Reviewed-by: Keith Randall Reviewed-by: Jorropo --- src/sync/once.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/sync') diff --git a/src/sync/once.go b/src/sync/once.go index 90840b19b5..1573b28b28 100644 --- a/src/sync/once.go +++ b/src/sync/once.go @@ -25,7 +25,7 @@ type Once struct { // The hot path is inlined at every call site. // Placing done first allows more compact instructions on some architectures (amd64/386), // and fewer instructions (to calculate offset) on other architectures. - done atomic.Uint32 + done atomic.Bool m Mutex } @@ -64,7 +64,7 @@ func (o *Once) Do(f func()) { // This is why the slow path falls back to a mutex, and why // the o.done.Store must be delayed until after f returns. - if o.done.Load() == 0 { + if !o.done.Load() { // Outlined slow-path to allow inlining of the fast-path. o.doSlow(f) } @@ -73,8 +73,8 @@ func (o *Once) Do(f func()) { func (o *Once) doSlow(f func()) { o.m.Lock() defer o.m.Unlock() - if o.done.Load() == 0 { - defer o.done.Store(1) + if !o.done.Load() { + defer o.done.Store(true) f() } } -- cgit v1.3-6-g1900