From 4d7cf3fedbc382215df5ff6167ee9782a9cc9375 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 6 Mar 2018 21:28:24 -0800 Subject: runtime: convert g.waitreason from string to uint8 Every time I poke at #14921, the g.waitreason string pointer writes show up. They're not particularly important performance-wise, but it'd be nice to clear the noise away. And it does open up a few extra bytes in the g struct for some future use. This is a re-roll of CL 99078, which was rolled back because of failures on s390x. Those failures were apparently due to an old version of gdb. Change-Id: Icc2c12f449b2934063fd61e272e06237625ed589 Reviewed-on: https://go-review.googlesource.com/111256 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Michael Munday --- src/runtime/traceback.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/runtime/traceback.go') diff --git a/src/runtime/traceback.go b/src/runtime/traceback.go index 0743449b3c..fd649cbbc6 100644 --- a/src/runtime/traceback.go +++ b/src/runtime/traceback.go @@ -872,8 +872,8 @@ func goroutineheader(gp *g) { } // Override. - if gpstatus == _Gwaiting && gp.waitreason != "" { - status = gp.waitreason + if gpstatus == _Gwaiting && gp.waitreason != waitReasonZero { + status = gp.waitreason.String() } // approx time the G is blocked, in minutes -- cgit v1.3-5-g9baa