From 7b5a34418cd32ec4d2c0f7d6e4c7e6fe7585a17f Mon Sep 17 00:00:00 2001 From: qmuntal Date: Mon, 23 Jan 2023 12:59:29 +0100 Subject: runtime: remove unused badsignal2 on windows This CL removes badsignal2 function, as it is unused on Windows. badsignal2 was originally intended to abort the process when an exception was raised on a non-Go thread, following the same approach as Linux and others. Since it was added, back on https://golang.org/cl/5797068, it has caused several issues on Windows, see #8224 and #50877. That's because we can't know wether the signal is bad or not, as our trap might not be at the end of the exception handler chain. To fix those issues, https://golang.org/cl/104200046 and CL 442896 stopped calling badsignal2, and CL 458135 removed one last incorrect call on amd64 and 386. Change-Id: I5bd31ee2672118ae0f1a2c8b46a1bb0f4893a011 Reviewed-on: https://go-review.googlesource.com/c/go/+/463116 Reviewed-by: Bryan Mills Run-TryBot: Quim Muntal Reviewed-by: Alex Brainman Reviewed-by: Cherry Mui TryBot-Result: Gopher Robot --- src/runtime/sys_windows_arm.s | 24 ------------------------ 1 file changed, 24 deletions(-) (limited to 'src/runtime/sys_windows_arm.s') diff --git a/src/runtime/sys_windows_arm.s b/src/runtime/sys_windows_arm.s index a00fd16670..78cc3333c7 100644 --- a/src/runtime/sys_windows_arm.s +++ b/src/runtime/sys_windows_arm.s @@ -76,30 +76,6 @@ loadregs: MOVM.IA.W (R13), [R4, R5, R15] -TEXT runtime·badsignal2(SB),NOSPLIT|NOFRAME,$0 - MOVM.DB.W [R4, R14], (R13) // push {r4, lr} - MOVW R13, R4 // save original stack pointer - SUB $8, R13 // space for 2 variables - BIC $0x7, R13 // alignment for ABI - - // stderr - MOVW runtime·_GetStdHandle(SB), R1 - MOVW $-12, R0 - BL (R1) - - MOVW $runtime·badsignalmsg(SB), R1 // lpBuffer - MOVW $runtime·badsignallen(SB), R2 // lpNumberOfBytesToWrite - MOVW (R2), R2 - ADD $0x4, R13, R3 // lpNumberOfBytesWritten - MOVW $0, R12 // lpOverlapped - MOVW R12, (R13) - - MOVW runtime·_WriteFile(SB), R12 - BL (R12) - - // Does not return. - B runtime·abort(SB) - TEXT runtime·getlasterror(SB),NOSPLIT,$0 MRC 15, 0, R0, C13, C0, 2 MOVW 0x34(R0), R0 -- cgit v1.3