From 07ad84009865b15d68cba036610d04c66bd3f5e8 Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Mon, 16 Sep 2019 16:53:23 -0700 Subject: runtime: remove unneeded noinline directives Now that mid-stack inlining reports backtraces correctly, we no longer need to protect against inlining in a few critical areas. Update #19348 Update #28640 Update #34276 Change-Id: Ie68487e6482c3a9509ecf7ecbbd40fe43cee8381 Reviewed-on: https://go-review.googlesource.com/c/go/+/195818 Reviewed-by: David Chase --- src/runtime/stack_test.go | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/runtime/stack_test.go') diff --git a/src/runtime/stack_test.go b/src/runtime/stack_test.go index 143d3a99a0..adfc65384a 100644 --- a/src/runtime/stack_test.go +++ b/src/runtime/stack_test.go @@ -599,9 +599,6 @@ func (s structWithMethod) callers() []uintptr { return pc[:Callers(0, pc)] } -// The noinline prevents this function from being inlined -// into a wrapper. TODO: remove this when issue 28640 is fixed. -//go:noinline func (s structWithMethod) stack() string { buf := make([]byte, 4<<10) return string(buf[:Stack(buf, false)]) -- cgit v1.3