From cc0a04d351c69a99f65342ad5822f2bba8b247d0 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 10 Feb 2016 21:46:51 -0800 Subject: runtime: fix errno sign for some mmap and mincore cases The caller of mmap expects it to return a positive errno value, but the linux-arm64 and nacl-386 system calls returned a negative errno value. Correct them to negate the errno value. The caller of mincore expects it to return a negative errno value (yes, this is inconsistent), but the linux-mips64x and linux-ppc64x system call returned a positive errno value. Correct them to negate the errno value. Add a test that mmap returns errno with the correct sign. Brad added a test for mincore's errno value in https://golang.org/cl/19457. Fixes #14297. Change-Id: I2b93f32e679bd1eae1c9aef9ae7bcf0ba39521b5 Reviewed-on: https://go-review.googlesource.com/19455 Reviewed-by: Brad Fitzpatrick Reviewed-by: Minux Ma Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/runtime/export_linux_test.go | 1 + 1 file changed, 1 insertion(+) (limited to 'src/runtime/export_linux_test.go') diff --git a/src/runtime/export_linux_test.go b/src/runtime/export_linux_test.go index c8b9746676..61d6ae4bf2 100644 --- a/src/runtime/export_linux_test.go +++ b/src/runtime/export_linux_test.go @@ -7,3 +7,4 @@ package runtime var NewOSProc0 = newosproc0 +var Mincore = mincore -- cgit v1.3