From d49719b1f75ea745937bdbc09ae5927c5378780b Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Tue, 1 Nov 2022 14:18:09 -0700 Subject: cmd/compile: move raw writes out of write barrier code Previously, the write barrier calls themselves did the actual writes to memory. Instead, move those writes out to a common location that both the wb-enabled and wb-disabled code paths share. This enables us to optimize the write barrier path without having to worry about performing the actual writes. Change-Id: Ia71ab651908ec124cc33141afb52e4ca19733ac6 Reviewed-on: https://go-review.googlesource.com/c/go/+/447780 Reviewed-by: Michael Knyszek TryBot-Bypass: Keith Randall Run-TryBot: Keith Randall Reviewed-by: Cherry Mui --- src/runtime/asm_arm.s | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/runtime/asm_arm.s') diff --git a/src/runtime/asm_arm.s b/src/runtime/asm_arm.s index 40a6e47792..3cabe748cd 100644 --- a/src/runtime/asm_arm.s +++ b/src/runtime/asm_arm.s @@ -899,8 +899,6 @@ retry: MOVW (R2), R0 // TODO: This turns bad writes into bad reads. MOVW R0, -4(R1) // Record *slot MOVM.IA.W (R13), [R0,R1] - // Do the write. - MOVW R3, (R2) RET flush: -- cgit v1.3