From ca6a0fee1b3f68ab4e9f8e1c7fbe80f178e68c09 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 15 Sep 2009 09:41:59 -0700 Subject: more "declared and not used". the last round omitted := range and only checked 1 out of N vars in a multi-var := R=r OCL=34624 CL=34638 --- src/pkg/strings/strings.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/pkg/strings/strings.go') diff --git a/src/pkg/strings/strings.go b/src/pkg/strings/strings.go index f0f0761576..4883d392cd 100644 --- a/src/pkg/strings/strings.go +++ b/src/pkg/strings/strings.go @@ -157,7 +157,7 @@ func Map(mapping func(rune int) int, s string) string { maxbytes := len(s); // length of b nbytes := 0; // number of bytes encoded in b b := make([]byte, maxbytes); - for i, c := range s { + for _, c := range s { rune := mapping(c); wid := 1; if rune >= utf8.RuneSelf { @@ -196,8 +196,8 @@ func Title(s string) string { // removed, as defined by Unicode. func TrimSpace(s string) string { start, end := 0, len(s); - for wid := 0; start < end; start += wid { - wid = 1; + for start < end { + wid := 1; rune := int(s[start]); if rune >= utf8.RuneSelf { rune, wid = utf8.DecodeRuneInString(s[start:end]) @@ -205,9 +205,10 @@ func TrimSpace(s string) string { if !unicode.IsSpace(rune) { break; } + start += wid; } - for wid := 0; start < end; end -= wid { - wid = 1; + for start < end { + wid := 1; rune := int(s[end-1]); if rune >= utf8.RuneSelf { // Back up carefully looking for beginning of rune. Mustn't pass start. @@ -221,6 +222,7 @@ func TrimSpace(s string) string { if !unicode.IsSpace(rune) { break; } + end -= wid; } return s[start:end]; } -- cgit v1.3