From fe91006a02b4892d95d1625889632aa4e0fe2b58 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Wed, 27 Aug 2014 14:08:26 -0400 Subject: runtime: give nosplit functions 32 more bytes of headroom The Go calling convention uses more stack space than C. On 64-bit systems we've been right up against the limit (128 bytes, so only 16 words) and doing awful things to our source code to work around it. Instead of continuing to do awful things, raise the limit to 160 bytes. I am prepared to raise the limit to 192 bytes if necessary, but I think this will be enough. Should fix current link-time stack overflow errors on - nacl/arm - netbsd/amd64 - openbsd/amd64 - solaris/amd64 - windows/amd64 TBR=r CC=golang-codereviews, iant https://golang.org/cl/131450043 --- src/pkg/runtime/stack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/pkg/runtime/stack.h') diff --git a/src/pkg/runtime/stack.h b/src/pkg/runtime/stack.h index ee5fd351d5..b2de78d898 100644 --- a/src/pkg/runtime/stack.h +++ b/src/pkg/runtime/stack.h @@ -94,7 +94,7 @@ enum { // After a stack split check the SP is allowed to be this // many bytes below the stack guard. This saves an instruction // in the checking sequence for tiny frames. - StackSmall = 128, + StackSmall = 96, // The maximum number of bytes that a chain of NOSPLIT // functions can use. -- cgit v1.3-5-g9baa