From 397bdb216f705a3e3221c98904237820d4950042 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Sat, 30 Aug 2014 00:56:52 -0400 Subject: runtime: increase nosplit area to 192 In CL 131450043, which raised it to 160, I'd raise it to 192 if necessary. Apparently it is necessary on windows/amd64. One note for those concerned about the growth: in the old segmented stack world, we wasted this much space at the bottom of every stack segment. In the new contiguous stack world, each goroutine has only one stack segment, so we only waste this much space once per goroutine. So even raising the limit further might still be a net savings. Fixes windows/amd64 build. TBR=r CC=golang-codereviews https://golang.org/cl/132480043 --- src/pkg/runtime/stack.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/pkg/runtime/stack.go') diff --git a/src/pkg/runtime/stack.go b/src/pkg/runtime/stack.go index ae7e96a005..ea27c1fb70 100644 --- a/src/pkg/runtime/stack.go +++ b/src/pkg/runtime/stack.go @@ -86,7 +86,7 @@ const ( // After a stack split check the SP is allowed to be this // many bytes below the stack guard. This saves an instruction // in the checking sequence for tiny frames. - stackSmall = 96 + stackSmall = 64 // The maximum number of bytes that a chain of NOSPLIT // functions can use. -- cgit v1.3-5-g9baa