From 431b96bdbe7dc838551efc9959b3bdca780b9368 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Mon, 19 May 2014 14:29:45 -0700 Subject: text/template,html/template: document that partial results may be written on error Fixes #7445. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/94640043 --- src/pkg/html/template/template.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/pkg/html') diff --git a/src/pkg/html/template/template.go b/src/pkg/html/template/template.go index 744f139ba4..d389658979 100644 --- a/src/pkg/html/template/template.go +++ b/src/pkg/html/template/template.go @@ -62,6 +62,9 @@ func (t *Template) escape() error { // Execute applies a parsed template to the specified data object, // writing the output to wr. +// If an error occurs executing the template or writing its output, +// execution stops, but partial results may already have been written to +// the output writer. // A template may be executed safely in parallel. func (t *Template) Execute(wr io.Writer, data interface{}) error { if err := t.escape(); err != nil { @@ -72,6 +75,9 @@ func (t *Template) Execute(wr io.Writer, data interface{}) error { // ExecuteTemplate applies the template associated with t that has the given // name to the specified data object and writes the output to wr. +// If an error occurs executing the template or writing its output, +// execution stops, but partial results may already have been written to +// the output writer. // A template may be executed safely in parallel. func (t *Template) ExecuteTemplate(wr io.Writer, name string, data interface{}) error { tmpl, err := t.lookupAndEscapeTemplate(name) -- cgit v1.3-5-g9baa