From 515e3de2999b23da28e6d15ac485bfdd299ec83a Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 5 Oct 2022 15:21:06 -0400 Subject: os/exec: parallelize more tests This cuts the wall duration for 'go test os/exec' and 'go test -race os/exec' roughly in half on my machine, which is an even more significant speedup with a high '-count'. For better or for worse, it may also increase the repro rate of #34988. Tests that use Setenv or Chdir or check for FDs opened during the test still cannot be parallelized, but they are only a few of those. Change-Id: I8d284d8bff05787853f825ef144aeb7a4126847f Reviewed-on: https://go-review.googlesource.com/c/go/+/439196 TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Run-TryBot: Bryan Mills Auto-Submit: Bryan Mills --- src/os/exec/exec_posix_test.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/os/exec/exec_posix_test.go') diff --git a/src/os/exec/exec_posix_test.go b/src/os/exec/exec_posix_test.go index f0401377e8..d366840bb1 100644 --- a/src/os/exec/exec_posix_test.go +++ b/src/os/exec/exec_posix_test.go @@ -49,6 +49,7 @@ func TestCredentialNoSetGroups(t *testing.T) { maySkipHelperCommand("echo") t.Skip("unsupported on Android") } + t.Parallel() u, err := user.Current() if err != nil { @@ -186,6 +187,8 @@ func TestImplicitPWD(t *testing.T) { // (This checks that the implementation for https://go.dev/issue/50599 doesn't // break existing users who may have explicitly mismatched the PWD variable.) func TestExplicitPWD(t *testing.T) { + t.Parallel() + maySkipHelperCommand("pwd") testenv.MustHaveSymlink(t) -- cgit v1.3-5-g9baa