From 6249ea2f39958764b88ab1b03cd55cf99dae6bbd Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Wed, 20 Mar 2019 14:09:51 -0700 Subject: os/exec: add Cmd.String The initial implementation is intentionally simple. Let's see how far it gets us. Fixes #30638 Change-Id: I240afae2b401744ab2ff2a69952c4eb0fd3feb56 Reviewed-on: https://go-review.googlesource.com/c/go/+/168518 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/os/exec/exec.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'src/os/exec/exec.go') diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go index 424b49cf06..d481cf7798 100644 --- a/src/os/exec/exec.go +++ b/src/os/exec/exec.go @@ -190,6 +190,25 @@ func CommandContext(ctx context.Context, name string, arg ...string) *Cmd { return cmd } +// String returns a human-readable description of c. +// It is intended only for debugging. +// In particular, it is not suitable for use as input to a shell. +// The output of String may vary across Go releases. +func (c *Cmd) String() string { + if c.lookPathErr != nil { + // failed to resolve path; report the original requested path (plus args) + return strings.Join(c.Args, " ") + } + // report the exact executable path (plus args) + b := new(strings.Builder) + b.WriteString(c.Path) + for _, a := range c.Args[1:] { + b.WriteByte(' ') + b.WriteString(a) + } + return b.String() +} + // interfaceEqual protects against panics from doing equality tests on // two interfaces with non-comparable underlying types. func interfaceEqual(a, b interface{}) bool { -- cgit v1.3