From b5aefe07e5afe2fd5d49c6a4219cc826b3e4e34e Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 14 Oct 2025 11:40:26 +0200 Subject: all: remove unnecessary loop variable copies in tests Copying the loop variable is no longer necessary since Go 1.22. Change-Id: Iebb21dac44a20ec200567f1d786f105a4ee4999d Reviewed-on: https://go-review.googlesource.com/c/go/+/711640 Reviewed-by: Florian Lehner Auto-Submit: Damien Neil Reviewed-by: Dmitri Shuralyov Reviewed-by: Damien Neil Auto-Submit: Tobias Klauser LUCI-TryBot-Result: Go LUCI --- src/net/http/fs_test.go | 1 - src/net/http/httptest/recorder_test.go | 1 - src/net/http/serve_test.go | 1 - src/net/http/transport_test.go | 1 - 4 files changed, 4 deletions(-) (limited to 'src/net/http') diff --git a/src/net/http/fs_test.go b/src/net/http/fs_test.go index 9b34ad080e..32fb696fee 100644 --- a/src/net/http/fs_test.go +++ b/src/net/http/fs_test.go @@ -1540,7 +1540,6 @@ func testServeFileRejectsInvalidSuffixLengths(t *testing.T, mode testMode) { } for _, tt := range tests { - tt := tt t.Run(tt.r, func(t *testing.T) { req, err := NewRequest("GET", cst.URL+"/index.html", nil) if err != nil { diff --git a/src/net/http/httptest/recorder_test.go b/src/net/http/httptest/recorder_test.go index 0996976514..9d1c4430c9 100644 --- a/src/net/http/httptest/recorder_test.go +++ b/src/net/http/httptest/recorder_test.go @@ -374,7 +374,6 @@ func TestRecorderPanicsOnNonXXXStatusCode(t *testing.T) { -100, 0, 99, 1000, 20000, } for _, badCode := range badCodes { - badCode := badCode t.Run(fmt.Sprintf("Code=%d", badCode), func(t *testing.T) { defer func() { if r := recover(); r == nil { diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index aee6288f3b..4a16ba02af 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -6701,7 +6701,6 @@ func testTimeoutHandlerSuperfluousLogs(t *testing.T, mode testMode) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { exitHandler := make(chan bool, 1) defer close(exitHandler) diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go index 75dbd25d22..8ab4107fb7 100644 --- a/src/net/http/transport_test.go +++ b/src/net/http/transport_test.go @@ -4526,7 +4526,6 @@ func TestTransportContentEncodingCaseInsensitive(t *testing.T) { } func testTransportContentEncodingCaseInsensitive(t *testing.T, mode testMode) { for _, ce := range []string{"gzip", "GZIP"} { - ce := ce t.Run(ce, func(t *testing.T) { const encodedString = "Hello Gopher" ts := newClientServerTest(t, mode, HandlerFunc(func(w ResponseWriter, r *Request) { -- cgit v1.3