From 84ded8ba8a0233a7f38e3c777dc1c213f98d00a2 Mon Sep 17 00:00:00 2001 From: Kenny Grant Date: Fri, 26 Aug 2016 22:21:00 +0100 Subject: net/http: make Server log on bad requests from clients Fixes #12745 Change-Id: Iebb7c97cb5b68dc080644d796a6ca1c120d41b26 Reviewed-on: https://go-review.googlesource.com/27950 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/net/http/clientserver_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/net/http/clientserver_test.go') diff --git a/src/net/http/clientserver_test.go b/src/net/http/clientserver_test.go index d70aabea74..3c4b7773a1 100644 --- a/src/net/http/clientserver_test.go +++ b/src/net/http/clientserver_test.go @@ -56,6 +56,10 @@ const ( h2Mode = true ) +var optQuietLog = func(ts *httptest.Server) { + ts.Config.ErrorLog = quietLog +} + func newClientServerTest(t *testing.T, h2 bool, h Handler, opts ...interface{}) *clientServerTest { cst := &clientServerTest{ t: t, @@ -1077,7 +1081,7 @@ func testTransportRejectsInvalidHeaders(t *testing.T, h2 bool) { defer afterTest(t) cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { fmt.Fprintf(w, "Handler saw headers: %q", r.Header) - })) + }), optQuietLog) defer cst.close() cst.tr.DisableKeepAlives = true -- cgit v1.3