From 23fd374bf22aa2eea9c07076061ef8cfbc6cf3d7 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Fri, 13 Mar 2015 17:24:30 -0700 Subject: math/big: wrap Float.Cmp result in struct to prevent wrong use Float.Cmp used to return a value < 0, 0, or > 0 depending on how arguments x, y compared against each other. With the possibility of NaNs, the result was changed into an Accuracy (to include Undef). Consequently, Float.Cmp results could still be compared for (in-) equality with 0, but comparing if < 0 or > 0 would provide the wrong answer w/o any obvious notice by the compiler. This change wraps Float.Cmp results into a struct and accessors are used to access the desired result. This prevents incorrect use. Change-Id: I34e6a6c1859251ec99b5cf953e82542025ace56f Reviewed-on: https://go-review.googlesource.com/7526 Reviewed-by: Rob Pike --- src/math/big/floatconv_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/math/big/floatconv_test.go') diff --git a/src/math/big/floatconv_test.go b/src/math/big/floatconv_test.go index e7920d0c07..17c8b14786 100644 --- a/src/math/big/floatconv_test.go +++ b/src/math/big/floatconv_test.go @@ -102,7 +102,7 @@ func TestFloatSetFloat64String(t *testing.T) { } f, _ := x.Float64() want := new(Float).SetFloat64(test.x) - if x.Cmp(want) != 0 { + if x.Cmp(want).Neq() { t.Errorf("%s: got %s (%v); want %v", test.s, &x, f, test.x) } } -- cgit v1.3-5-g9baa