From 98aaa9b0ee54ba197432458a6f344c14aa12c106 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Tue, 24 Mar 2026 12:29:02 -0400 Subject: cmd/dist: add GO_TEST_ASMFLAGS to set -asmflags during dist test If we run into a need for finer control over when -asmflags gets set, there can be an asmflags field added to goTest, analogously to the existing gcflags and ldflags fields. Start with a minimal change for what is currently needed, since not adding something we ourselves don't use makes it easier to avoid inadvertently ending up maintaining it because we can't be sure whether someone else started to depend on it. For #77427. Change-Id: I5e80874861cadf95fe770af6712b2c3f172c990a Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-spectre Reviewed-on: https://go-review.googlesource.com/c/go/+/758740 Reviewed-by: Michael Pratt Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Auto-Submit: Dmitri Shuralyov --- src/internal/testenv/testenv_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/internal/testenv') diff --git a/src/internal/testenv/testenv_test.go b/src/internal/testenv/testenv_test.go index 769db3a033..8313079983 100644 --- a/src/internal/testenv/testenv_test.go +++ b/src/internal/testenv/testenv_test.go @@ -97,8 +97,9 @@ func TestHasGoBuild(t *testing.T) { } } - if strings.Contains(b, "-noopt") { - // The -noopt builder sets GO_GCFLAGS, which causes tests of 'go build' to + if strings.Contains(b, "-noopt") || + strings.Contains(b, "-spectre") { + // These builders set GO_GCFLAGS, which causes tests of 'go build' to // be skipped. t.Logf("HasGoBuild is false on %s", b) return -- cgit v1.3-5-g9baa